Remove export column from equality

Author: gbrgr

sdks/julia/LogicalQueryProtocol.jl/src/equality.jl

@@ -365,20 +365,11 @@ Base.isequal(a::IcebergCatalogConfig, b::IcebergCatalogConfig) =
     isequal(a.scope, b.scope) &&
     isequal(a.properties, b.properties)
 
-# ExportColumn
-Base.:(==)(a::ExportColumn, b::ExportColumn) =
-    a.name == b.name && a.nullable == b.nullable
-Base.hash(a::ExportColumn, h::UInt) =
-    hash(a.nullable, hash(a.name, h))
-Base.isequal(a::ExportColumn, b::ExportColumn) =
-    isequal(a.name, b.name) && isequal(a.nullable, b.nullable)
-
 # ExportIcebergConfig
 Base.:(==)(a::ExportIcebergConfig, b::ExportIcebergConfig) =
     a.locator == b.locator &&
     a.config == b.config &&
     a.table_def == b.table_def &&
-    a.columns == b.columns &&
     a.prefix == b.prefix &&
     a.target_file_size_bytes == b.target_file_size_bytes &&
     a.compression == b.compression &&
@@ -389,15 +380,14 @@ Base.hash(a::ExportIcebergConfig, h::UInt) = hash(
         a.compression,
         hash(
             a.target_file_size_bytes,
-            hash(a.prefix, hash(a.columns, hash(a.table_def, hash(a.config, hash(a.locator, h))))),
+            hash(a.prefix, hash(a.table_def, hash(a.config, hash(a.locator, h)))),
         ),
     ),
 )
 Base.isequal(a::ExportIcebergConfig, b::ExportIcebergConfig) =
     isequal(a.locator, b.locator) &&
     isequal(a.config, b.config) &&
     isequal(a.table_def, b.table_def) &&
-    isequal(a.columns, b.columns) &&
     isequal(a.prefix, b.prefix) &&
     isequal(a.target_file_size_bytes, b.target_file_size_bytes) &&
     isequal(a.compression, b.compression) &&

sdks/julia/LogicalQueryProtocol.jl/test/equality_tests.jl

@@ -2262,35 +2262,18 @@ end
     @test a == a
 end
 
-@testitem "Equality for ExportColumn" tags=[:ring1, :unit] begin
-    using LogicalQueryProtocol: ExportColumn
-
-    a = ExportColumn(name="col1", nullable=false)
-    b = ExportColumn(name="col1", nullable=false)
-    c = ExportColumn(name="col2", nullable=false)
-    d = ExportColumn(name="col1", nullable=true)
-
-    @test a == b
-    @test a != c
-    @test a != d
-    @test isequal(a, b)
-    @test hash(a) == hash(b)
-    @test a == a
-end
-
 @testitem "Equality for ExportIcebergConfig" tags=[:ring1, :unit] begin
-    using LogicalQueryProtocol: ExportIcebergConfig, ExportColumn, IcebergLocator, IcebergCatalogConfig, RelationId
+    using LogicalQueryProtocol: ExportIcebergConfig, IcebergLocator, IcebergCatalogConfig, RelationId
 
     loc = IcebergLocator(table_name="t", namespace=["n"], warehouse="w")
     cfg = IcebergCatalogConfig(catalog_uri="uri", scope="", properties=Dict(), auth_properties=Dict())
     rid = RelationId(id_low=1, id_high=0)
-    cols = [ExportColumn(name="c1", nullable=false)]
 
-    a = ExportIcebergConfig(locator=loc, config=cfg, table_def=rid, columns=cols, prefix="", target_file_size_bytes=0, compression="", table_properties=Dict())
-    b = ExportIcebergConfig(locator=loc, config=cfg, table_def=rid, columns=cols, prefix="", target_file_size_bytes=0, compression="", table_properties=Dict())
-    c = ExportIcebergConfig(locator=loc, config=cfg, table_def=rid, columns=cols, prefix="pfx", target_file_size_bytes=0, compression="", table_properties=Dict())
-    d = ExportIcebergConfig(locator=loc, config=cfg, table_def=rid, columns=cols, prefix="", target_file_size_bytes=0, compression="SNAPPY", table_properties=Dict())
-    e = ExportIcebergConfig(locator=loc, config=cfg, table_def=rid, columns=cols, prefix="", target_file_size_bytes=0, compression="", table_properties=Dict("k" => "v"))
+    a = ExportIcebergConfig(locator=loc, config=cfg, table_def=rid, prefix="", target_file_size_bytes=0, compression="", table_properties=Dict())
+    b = ExportIcebergConfig(locator=loc, config=cfg, table_def=rid, prefix="", target_file_size_bytes=0, compression="", table_properties=Dict())
+    c = ExportIcebergConfig(locator=loc, config=cfg, table_def=rid, prefix="pfx", target_file_size_bytes=0, compression="", table_properties=Dict())
+    d = ExportIcebergConfig(locator=loc, config=cfg, table_def=rid, prefix="", target_file_size_bytes=0, compression="SNAPPY", table_properties=Dict())
+    e = ExportIcebergConfig(locator=loc, config=cfg, table_def=rid, prefix="", target_file_size_bytes=0, compression="", table_properties=Dict("k" => "v"))
 
     @test a == b
     @test a != c