Rename CdcTargets proto message to CDCTargets

hbarthels · claude · hbarthels · commit 1b0b13ccb9ea · 2026-06-23T17:16:08.000+02:00
Use the conventional all-caps CDC acronym for the message name. The
oneof field stays `cdc`; only the message type name changes, so there is
no wire-format or s-expression syntax change (no .bin/snapshot diffs).
Regenerated all three SDKs and updated the hand-written Julia equality +
equality tests.

Co-Authored-By: Claude Opus 4.8 &lt;noreply@anthropic.com&gt;
diff --git a/meta/src/meta/grammar.y b/meta/src/meta/grammar.y
@@ -1541,7 +1541,7 @@ def construct_cdc_relations(
 ) -> logic.TargetRelations:
     return logic.TargetRelations(
         keys=list[logic.NamedColumn](),
-        cdc=logic.CdcTargets(inserts=inserts, deletes=deletes),
+        cdc=logic.CDCTargets(inserts=inserts, deletes=deletes),
     )
 
 
diff --git a/proto/relationalai/lqp/v1/logic.proto b/proto/relationalai/lqp/v1/logic.proto
@@ -307,7 +307,7 @@ message PlainTargets {
 }
 
 // CDC load: input rows are routed by METADATA$ACTION into insert and delete deltas.
-message CdcTargets {
+message CDCTargets {
   repeated TargetRelation inserts = 1; // INSERT-action rows feed these
   repeated TargetRelation deletes = 2; // DELETE-action rows feed these
 }
@@ -318,7 +318,7 @@ message TargetRelations {
   repeated NamedColumn keys = 1; // Shared key columns (name "METADATA$KEY" => derived hash)
   oneof body {
     PlainTargets plain = 2;
-    CdcTargets cdc = 3;
+    CDCTargets cdc = 3;
   }
 }
 
diff --git a/sdks/go/src/lqp/v1/logic.pb.go b/sdks/go/src/lqp/v1/logic.pb.go
diff --git a/sdks/go/src/parser.go b/sdks/go/src/parser.go
@@ -743,7 +743,7 @@ func (p *Parser) construct_non_cdc_relations(targets []*pb.TargetRelation) *pb.T
 }
 
 func (p *Parser) construct_cdc_relations(inserts []*pb.TargetRelation, deletes []*pb.TargetRelation) *pb.TargetRelations {
-	_t2211 := &pb.CdcTargets{Inserts: inserts, Deletes: deletes}
+	_t2211 := &pb.CDCTargets{Inserts: inserts, Deletes: deletes}
 	_t2212 := &pb.TargetRelations{Keys: []*pb.NamedColumn{}}
 	_t2212.Body = &pb.TargetRelations_Cdc{Cdc: _t2211}
 	return _t2212
diff --git a/sdks/go/src/pretty.go b/sdks/go/src/pretty.go
@@ -5311,7 +5311,7 @@ func (p *PrettyPrinter) pretty_be_tree_locator(msg *pb.BeTreeLocator) interface{
 	return nil
 }
 
-func (p *PrettyPrinter) pretty_cdc_targets(msg *pb.CdcTargets) interface{} {
+func (p *PrettyPrinter) pretty_cdc_targets(msg *pb.CDCTargets) interface{} {
 	p.write("(cdc_targets")
 	p.indentSexp()
 	p.newline()
@@ -5706,7 +5706,7 @@ func (p *PrettyPrinter) pprintDispatch(msg interface{}) {
 		p.pretty_be_tree_config(m)
 	case *pb.BeTreeLocator:
 		p.pretty_be_tree_locator(m)
-	case *pb.CdcTargets:
+	case *pb.CDCTargets:
 		p.pretty_cdc_targets(m)
 	case *pb.DecimalValue:
 		p.pretty_decimal_value(m)
diff --git a/sdks/julia/LogicalQueryProtocol.jl/src/equality.jl b/sdks/julia/LogicalQueryProtocol.jl/src/equality.jl
@@ -591,10 +591,10 @@ Base.:(==)(a::PlainTargets, b::PlainTargets) = a.targets == b.targets
 Base.hash(a::PlainTargets, h::UInt) = hash(a.targets, h)
 Base.isequal(a::PlainTargets, b::PlainTargets) = isequal(a.targets, b.targets)
 
-# CdcTargets
-Base.:(==)(a::CdcTargets, b::CdcTargets) = a.inserts == b.inserts && a.deletes == b.deletes
-Base.hash(a::CdcTargets, h::UInt) = hash(a.deletes, hash(a.inserts, h))
-Base.isequal(a::CdcTargets, b::CdcTargets) = isequal(a.inserts, b.inserts) && isequal(a.deletes, b.deletes)
+# CDCTargets
+Base.:(==)(a::CDCTargets, b::CDCTargets) = a.inserts == b.inserts && a.deletes == b.deletes
+Base.hash(a::CDCTargets, h::UInt) = hash(a.deletes, hash(a.inserts, h))
+Base.isequal(a::CDCTargets, b::CDCTargets) = isequal(a.inserts, b.inserts) && isequal(a.deletes, b.deletes)
 
 # TargetRelations
 Base.:(==)(a::TargetRelations, b::TargetRelations) = a.keys == b.keys && _isequal_oneof(a.body, b.body)
diff --git a/sdks/julia/LogicalQueryProtocol.jl/src/gen/relationalai/lqp/v1/logic_pb.jl b/sdks/julia/LogicalQueryProtocol.jl/src/gen/relationalai/lqp/v1/logic_pb.jl
@@ -12,7 +12,7 @@ export MissingType, MissingValue, IntType, StringType, Int128Value, UInt128Value
 export StorageIntegration, BooleanType, UInt32Type, DecimalValue, BeTreeLocator, CSVConfig
 export var"#Type", Value, NamedColumn, GNFColumn, MinMonoid, SumMonoid, MaxMonoid
 export BeTreeInfo, Binding, EDB, Attribute, Term, TargetRelation, IcebergData, Monoid
-export BeTreeRelation, Cast, Pragma, Atom, RelTerm, CdcTargets, PlainTargets, Primitive
+export BeTreeRelation, Cast, Pragma, Atom, RelTerm, CDCTargets, PlainTargets, Primitive
 export RelAtom, TargetRelations, CSVData, Data, Abstraction, Algorithm, Assign, Break
 export Conjunction, Constraint, Def, Disjunction, Exists, FFI, FunctionalDependency
 export MonoidDef, MonusDef, Not, Reduce, Script, Upsert, Construct, Loop, Declaration
@@ -2018,15 +2018,15 @@ function PB._encoded_size(x::RelTerm)
     return encoded_size
 end
 
-struct CdcTargets
+struct CDCTargets
     inserts::Vector{TargetRelation}
     deletes::Vector{TargetRelation}
 end
-CdcTargets(;inserts = Vector{TargetRelation}(), deletes = Vector{TargetRelation}()) = CdcTargets(inserts, deletes)
-PB.default_values(::Type{CdcTargets}) = (;inserts = Vector{TargetRelation}(), deletes = Vector{TargetRelation}())
-PB.field_numbers(::Type{CdcTargets}) = (;inserts = 1, deletes = 2)
+CDCTargets(;inserts = Vector{TargetRelation}(), deletes = Vector{TargetRelation}()) = CDCTargets(inserts, deletes)
+PB.default_values(::Type{CDCTargets}) = (;inserts = Vector{TargetRelation}(), deletes = Vector{TargetRelation}())
+PB.field_numbers(::Type{CDCTargets}) = (;inserts = 1, deletes = 2)
 
-function PB.decode(d::PB.AbstractProtoDecoder, ::Type{<:CdcTargets}, _endpos::Int=0, _group::Bool=false)
+function PB.decode(d::PB.AbstractProtoDecoder, ::Type{<:CDCTargets}, _endpos::Int=0, _group::Bool=false)
     inserts = PB.BufferedVector{TargetRelation}()
     deletes = PB.BufferedVector{TargetRelation}()
     while !PB.message_done(d, _endpos, _group)
@@ -2039,16 +2039,16 @@ function PB.decode(d::PB.AbstractProtoDecoder, ::Type{<:CdcTargets}, _endpos::In
             Base.skip(d, wire_type)
         end
     end
-    return CdcTargets(inserts[], deletes[])
+    return CDCTargets(inserts[], deletes[])
 end
 
-function PB.encode(e::PB.AbstractProtoEncoder, x::CdcTargets)
+function PB.encode(e::PB.AbstractProtoEncoder, x::CDCTargets)
     initpos = position(e.io)
     !isempty(x.inserts) && PB.encode(e, 1, x.inserts)
     !isempty(x.deletes) && PB.encode(e, 2, x.deletes)
     return position(e.io) - initpos
 end
-function PB._encoded_size(x::CdcTargets)
+function PB._encoded_size(x::CDCTargets)
     encoded_size = 0
     !isempty(x.inserts) && (encoded_size += PB._encoded_size(x.inserts, 1))
     !isempty(x.deletes) && (encoded_size += PB._encoded_size(x.deletes, 2))
@@ -2162,11 +2162,11 @@ end
 
 struct TargetRelations
     keys::Vector{NamedColumn}
-    body::Union{Nothing,OneOf{<:Union{PlainTargets,CdcTargets}}}
+    body::Union{Nothing,OneOf{<:Union{PlainTargets,CDCTargets}}}
 end
 TargetRelations(;keys = Vector{NamedColumn}(), body = nothing) = TargetRelations(keys, body)
 PB.oneof_field_types(::Type{TargetRelations}) = (;
-    body = (;plain=PlainTargets, cdc=CdcTargets),
+    body = (;plain=PlainTargets, cdc=CDCTargets),
 )
 PB.default_values(::Type{TargetRelations}) = (;keys = Vector{NamedColumn}(), plain = nothing, cdc = nothing)
 PB.field_numbers(::Type{TargetRelations}) = (;keys = 1, plain = 2, cdc = 3)
@@ -2181,7 +2181,7 @@ function PB.decode(d::PB.AbstractProtoDecoder, ::Type{<:TargetRelations}, _endpo
         elseif field_number == 2
             body = OneOf(:plain, PB.decode(d, Ref{PlainTargets}))
         elseif field_number == 3
-            body = OneOf(:cdc, PB.decode(d, Ref{CdcTargets}))
+            body = OneOf(:cdc, PB.decode(d, Ref{CDCTargets}))
         else
             Base.skip(d, wire_type)
         end
@@ -2196,7 +2196,7 @@ function PB.encode(e::PB.AbstractProtoEncoder, x::TargetRelations)
     elseif x.body.name === :plain
         PB.encode(e, 2, x.body[]::PlainTargets)
     elseif x.body.name === :cdc
-        PB.encode(e, 3, x.body[]::CdcTargets)
+        PB.encode(e, 3, x.body[]::CDCTargets)
     end
     return position(e.io) - initpos
 end
@@ -2207,7 +2207,7 @@ function PB._encoded_size(x::TargetRelations)
     elseif x.body.name === :plain
         encoded_size += PB._encoded_size(x.body[]::PlainTargets, 2)
     elseif x.body.name === :cdc
-        encoded_size += PB._encoded_size(x.body[]::CdcTargets, 3)
+        encoded_size += PB._encoded_size(x.body[]::CDCTargets, 3)
     end
     return encoded_size
 end
diff --git a/sdks/julia/LogicalQueryProtocol.jl/src/parser.jl b/sdks/julia/LogicalQueryProtocol.jl/src/parser.jl
@@ -456,7 +456,7 @@ function construct_non_cdc_relations(parser::ParserState, targets::Vector{Proto.
 end
 
 function construct_cdc_relations(parser::ParserState, inserts::Vector{Proto.TargetRelation}, deletes::Vector{Proto.TargetRelation})::Proto.TargetRelations
-    _t2198 = Proto.CdcTargets(inserts=inserts, deletes=deletes)
+    _t2198 = Proto.CDCTargets(inserts=inserts, deletes=deletes)
     _t2199 = Proto.TargetRelations(body=OneOf(:cdc, _t2198), keys=Proto.NamedColumn[])
     return _t2199
 end
diff --git a/sdks/julia/LogicalQueryProtocol.jl/src/pretty.jl b/sdks/julia/LogicalQueryProtocol.jl/src/pretty.jl
@@ -5383,7 +5383,7 @@ function pretty_be_tree_locator(pp::PrettyPrinter, msg::Proto.BeTreeLocator)
     return nothing
 end
 
-function pretty_cdc_targets(pp::PrettyPrinter, msg::Proto.CdcTargets)
+function pretty_cdc_targets(pp::PrettyPrinter, msg::Proto.CDCTargets)
     write(pp, "(cdc_targets")
     indent_sexp!(pp)
     newline(pp)
@@ -5664,7 +5664,7 @@ _pprint_dispatch(pp::PrettyPrinter, x::Proto.ExportIcebergConfig) = pretty_expor
 _pprint_dispatch(pp::PrettyPrinter, x::Proto.DebugInfo) = pretty_debug_info(pp, x)
 _pprint_dispatch(pp::PrettyPrinter, x::Proto.BeTreeConfig) = pretty_be_tree_config(pp, x)
 _pprint_dispatch(pp::PrettyPrinter, x::Proto.BeTreeLocator) = pretty_be_tree_locator(pp, x)
-_pprint_dispatch(pp::PrettyPrinter, x::Proto.CdcTargets) = pretty_cdc_targets(pp, x)
+_pprint_dispatch(pp::PrettyPrinter, x::Proto.CDCTargets) = pretty_cdc_targets(pp, x)
 _pprint_dispatch(pp::PrettyPrinter, x::Proto.DecimalValue) = pretty_decimal_value(pp, x)
 _pprint_dispatch(pp::PrettyPrinter, x::Proto.FunctionalDependency) = pretty_functional_dependency(pp, x)
 _pprint_dispatch(pp::PrettyPrinter, x::Proto.Int128Value) = pretty_int128_value(pp, x)
diff --git a/sdks/julia/LogicalQueryProtocol.jl/test/equality_tests.jl b/sdks/julia/LogicalQueryProtocol.jl/test/equality_tests.jl
@@ -2237,20 +2237,20 @@ end
     @test p1 == p2 && p2 == p5 && p1 == p5
 end
 
-@testitem "Equality for CdcTargets" tags=[:ring1, :unit] begin
-    using LogicalQueryProtocol: CdcTargets, TargetRelation, NamedColumn, RelationId, var"#Type", FloatType
+@testitem "Equality for CDCTargets" tags=[:ring1, :unit] begin
+    using LogicalQueryProtocol: CDCTargets, TargetRelation, NamedColumn, RelationId, var"#Type", FloatType
     using ProtoBuf: OneOf
 
     t1 = var"#Type"(var"#type"=OneOf(:float_type, FloatType()))
     val = NamedColumn(name="weight", var"#type"=t1)
     rel1 = TargetRelation(target_id=RelationId(id_low=1, id_high=0), values=[val])
     rel2 = TargetRelation(target_id=RelationId(id_low=2, id_high=0), values=[val])
 
-    c1 = CdcTargets(inserts=[rel1], deletes=[rel2])
-    c2 = CdcTargets(inserts=[rel1], deletes=[rel2])
-    c3 = CdcTargets(inserts=[rel2], deletes=[rel2])   # different inserts
-    c4 = CdcTargets(inserts=[rel1], deletes=[rel1])   # different deletes
-    c5 = CdcTargets(inserts=[rel1], deletes=[rel2])
+    c1 = CDCTargets(inserts=[rel1], deletes=[rel2])
+    c2 = CDCTargets(inserts=[rel1], deletes=[rel2])
+    c3 = CDCTargets(inserts=[rel2], deletes=[rel2])   # different inserts
+    c4 = CDCTargets(inserts=[rel1], deletes=[rel1])   # different deletes
+    c5 = CDCTargets(inserts=[rel1], deletes=[rel2])
 
     # Equality and inequality
     @test c1 == c2
@@ -2273,7 +2273,7 @@ end
 end
 
 @testitem "Equality for TargetRelations" tags=[:ring1, :unit] begin
-    using LogicalQueryProtocol: TargetRelations, PlainTargets, CdcTargets, TargetRelation, NamedColumn, RelationId, var"#Type", IntType, FloatType
+    using LogicalQueryProtocol: TargetRelations, PlainTargets, CDCTargets, TargetRelation, NamedColumn, RelationId, var"#Type", IntType, FloatType
     using ProtoBuf: OneOf
 
     tint = var"#Type"(var"#type"=OneOf(:int_type, IntType()))
@@ -2286,7 +2286,7 @@ end
     rel2 = TargetRelation(target_id=r2, values=[val])
 
     plain(rs) = OneOf(:plain, PlainTargets(targets=rs))
-    cdc(ins, dels) = OneOf(:cdc, CdcTargets(inserts=ins, deletes=dels))
+    cdc(ins, dels) = OneOf(:cdc, CDCTargets(inserts=ins, deletes=dels))
 
     # Plain (non-CDC) body.
     g1 = TargetRelations(keys=[key], body=plain([rel1]))
diff --git a/sdks/python/src/lqp/gen/parser.py b/sdks/python/src/lqp/gen/parser.py
@@ -544,7 +544,7 @@ def construct_non_cdc_relations(self, targets: Sequence[logic_pb2.TargetRelation
         return _t2206
 
     def construct_cdc_relations(self, inserts: Sequence[logic_pb2.TargetRelation], deletes: Sequence[logic_pb2.TargetRelation]) -> logic_pb2.TargetRelations:
-        _t2207 = logic_pb2.CdcTargets(inserts=inserts, deletes=deletes)
+        _t2207 = logic_pb2.CDCTargets(inserts=inserts, deletes=deletes)
         _t2208 = logic_pb2.TargetRelations(keys=[], cdc=_t2207)
         return _t2208
 
diff --git a/sdks/python/src/lqp/gen/pretty.py b/sdks/python/src/lqp/gen/pretty.py
@@ -4642,7 +4642,7 @@ def pretty_be_tree_locator(self, msg: logic_pb2.BeTreeLocator):
         self.write(")")
         self.dedent()
 
-    def pretty_cdc_targets(self, msg: logic_pb2.CdcTargets):
+    def pretty_cdc_targets(self, msg: logic_pb2.CDCTargets):
         self.write("(cdc_targets")
         self.indent_sexp()
         self.newline()
@@ -4957,7 +4957,7 @@ def pprint_dispatch(self, msg):
             self.pretty_be_tree_config(msg)
         elif isinstance(msg, logic_pb2.BeTreeLocator):
             self.pretty_be_tree_locator(msg)
-        elif isinstance(msg, logic_pb2.CdcTargets):
+        elif isinstance(msg, logic_pb2.CDCTargets):
             self.pretty_cdc_targets(msg)
         elif isinstance(msg, logic_pb2.DecimalValue):
             self.pretty_decimal_value(msg)
diff --git a/sdks/python/src/lqp/proto/v1/logic_pb2.py b/sdks/python/src/lqp/proto/v1/logic_pb2.py
diff --git a/sdks/python/src/lqp/proto/v1/logic_pb2.pyi b/sdks/python/src/lqp/proto/v1/logic_pb2.pyi

Original file line number	Diff line number	Diff line change
`@@ -1541,7 +1541,7 @@ def construct_cdc_relations(`
`1541`	`1541`	`) -> logic.TargetRelations:`
`1542`	`1542`	`return logic.TargetRelations(`
`1543`	`1543`	`keys=list[logic.NamedColumn](),`
`1544`		`- cdc=logic.CdcTargets(inserts=inserts, deletes=deletes),`
	`1544`	`+ cdc=logic.CDCTargets(inserts=inserts, deletes=deletes),`
`1545`	`1545`	`)`
`1546`	`1546`
`1547`	`1547`
Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ message PlainTargets {`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`// CDC load: input rows are routed by METADATA$ACTION into insert and delete deltas.`
`310`		`-message CdcTargets {`
	`310`	`+message CDCTargets {`
`311`	`311`	`repeated TargetRelation inserts = 1; // INSERT-action rows feed these`
`312`	`312`	`repeated TargetRelation deletes = 2; // DELETE-action rows feed these`
`313`	`313`	`}`
`@@ -318,7 +318,7 @@ message TargetRelations {`
`318`	`318`	`repeated NamedColumn keys = 1; // Shared key columns (name "METADATA$KEY" => derived hash)`
`319`	`319`	`oneof body {`
`320`	`320`	`PlainTargets plain = 2;`
`321`		`- CdcTargets cdc = 3;`
	`321`	`+ CDCTargets cdc = 3;`
`322`	`322`	`}`
`323`	`323`	`}`
`324`	`324`
Original file line number	Diff line number	Diff line change
`@@ -743,7 +743,7 @@ func (p Parser) construct_non_cdc_relations(targets []pb.TargetRelation) *pb.T`
`743`	`743`	`}`
`744`	`744`
`745`	`745`	`func (p Parser) construct_cdc_relations(inserts []pb.TargetRelation, deletes []pb.TargetRelation) pb.TargetRelations {`
`746`		`- _t2211 := &pb.CdcTargets{Inserts: inserts, Deletes: deletes}`
	`746`	`+ _t2211 := &pb.CDCTargets{Inserts: inserts, Deletes: deletes}`
`747`	`747`	`_t2212 := &pb.TargetRelations{Keys: []*pb.NamedColumn{}}`
`748`	`748`	`_t2212.Body = &pb.TargetRelations_Cdc{Cdc: _t2211}`
`749`	`749`	`return _t2212`