Skip to content

Commit 33b156b

Browse files
authored
Fix Julia package registration issues (#212)
* Rename directory to have jl at the end * Add MIT license * Add Manifest * Fix CI job
1 parent bc5a717 commit 33b156b

40 files changed

Lines changed: 36 additions & 21 deletions

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ jobs:
7171

7272
- name: Run tests
7373
run: |
74-
cd sdks/julia/LogicalQueryProtocol
74+
cd sdks/julia/LogicalQueryProtocol.jl
7575
julia --project=. -e 'using Pkg; Pkg.instantiate(); Pkg.test()'
7676
7777
go-test:

.gitignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ sdks/python/out/
1616
sdks/python/.lsp/.cache
1717
sdks/python/.clj-kondo
1818

19-
# Julia SDK
20-
sdks/julia/LogicalQueryProtocol/Manifest.toml
21-
2219
# Go SDK
2320
sdks/go/test/lqp_pretty_output
2421

Makefile

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,18 @@ GRAMMAR := meta/src/meta/grammar.y
3030

3131
# Generated protobuf outputs
3232
PY_PROTO_DIR := sdks/python/src/lqp/proto/v1
33-
JL_PROTO_DIR := sdks/julia/LogicalQueryProtocol/src/gen/relationalai/lqp/v1
33+
JL_PROTO_DIR := sdks/julia/LogicalQueryProtocol.jl/src/gen/relationalai/lqp/v1
3434
GO_PROTO_DIR := sdks/go/src/lqp/v1
3535

3636
# Generated parser outputs
3737
PY_PARSER := sdks/python/src/lqp/gen/parser.py
38-
JL_PARSER := sdks/julia/LogicalQueryProtocol/src/parser.jl
38+
JL_PARSER := sdks/julia/LogicalQueryProtocol.jl/src/parser.jl
3939
GO_PARSER := sdks/go/src/parser.go
4040

4141
# Generated printer outputs
4242
PY_PRINTER := sdks/python/src/lqp/gen/pretty.py
4343
GO_PRINTER := sdks/go/src/pretty.go
44-
JL_PRINTER := sdks/julia/LogicalQueryProtocol/src/pretty.jl
44+
JL_PRINTER := sdks/julia/LogicalQueryProtocol.jl/src/pretty.jl
4545

4646
# Parser templates
4747
PY_TEMPLATE := meta/src/meta/templates/parser.py.template
@@ -111,7 +111,7 @@ $(PY_PROTO_GENERATED) $(GO_PROTO_GENERATED): $(PROTO_FILES)
111111
$(JL_PROTO_GENERATED): $(PROTO_FILES)
112112
buf lint
113113
buf breaking --against ".git#branch=main,subdir=proto"
114-
cd sdks/julia && julia --project=LogicalQueryProtocol generate_proto.jl
114+
cd sdks/julia && julia --project=LogicalQueryProtocol.jl generate_proto.jl
115115

116116
# ---------- parser generation ----------
117117

@@ -123,7 +123,7 @@ $(PY_PARSER): $(PROTO_FILES) $(GRAMMAR) $(PY_TEMPLATE)
123123

124124
parser-julia: $(JL_PARSER)
125125
$(JL_PARSER): $(PROTO_FILES) $(GRAMMAR) $(JL_TEMPLATE)
126-
$(META_CLI) $(META_PROTO_ARGS) --parser julia -o ../sdks/julia/LogicalQueryProtocol/src/parser.jl
126+
$(META_CLI) $(META_PROTO_ARGS) --parser julia -o ../sdks/julia/LogicalQueryProtocol.jl/src/parser.jl
127127

128128
parser-go: $(GO_PARSER)
129129
$(GO_PARSER): $(PROTO_FILES) $(GRAMMAR) $(GO_TEMPLATE)
@@ -135,7 +135,7 @@ force-parser-python:
135135
$(META_CLI) $(META_PROTO_ARGS) --parser python -o ../sdks/python/src/lqp/gen/parser.py
136136

137137
force-parser-julia:
138-
$(META_CLI) $(META_PROTO_ARGS) --parser julia -o ../sdks/julia/LogicalQueryProtocol/src/parser.jl
138+
$(META_CLI) $(META_PROTO_ARGS) --parser julia -o ../sdks/julia/LogicalQueryProtocol.jl/src/parser.jl
139139

140140
force-parser-go:
141141
$(META_CLI) $(META_PROTO_ARGS) --parser go -o ../sdks/go/src/parser.go
@@ -150,7 +150,7 @@ $(PY_PRINTER): $(PROTO_FILES) $(GRAMMAR) $(PY_PRINTER_TEMPLATE)
150150

151151
printer-julia: $(JL_PRINTER)
152152
$(JL_PRINTER): $(PROTO_FILES) $(GRAMMAR) $(JL_PRINTER_TEMPLATE)
153-
$(META_CLI) $(META_PROTO_ARGS) --printer julia -o ../sdks/julia/LogicalQueryProtocol/src/pretty.jl
153+
$(META_CLI) $(META_PROTO_ARGS) --printer julia -o ../sdks/julia/LogicalQueryProtocol.jl/src/pretty.jl
154154

155155
printer-go: $(GO_PRINTER)
156156
$(GO_PRINTER): $(PROTO_FILES) $(GRAMMAR) $(GO_PRINTER_TEMPLATE)
@@ -162,7 +162,7 @@ force-printer-python:
162162
$(META_CLI) $(META_PROTO_ARGS) --printer python -o ../sdks/python/src/lqp/gen/pretty.py
163163

164164
force-printer-julia:
165-
$(META_CLI) $(META_PROTO_ARGS) --printer julia -o ../sdks/julia/LogicalQueryProtocol/src/pretty.jl
165+
$(META_CLI) $(META_PROTO_ARGS) --printer julia -o ../sdks/julia/LogicalQueryProtocol.jl/src/pretty.jl
166166

167167
force-printer-go:
168168
$(META_CLI) $(META_PROTO_ARGS) --printer go -o ../sdks/go/src/pretty.go
@@ -178,7 +178,7 @@ update-snapshots: $(PY_PARSER) $(PY_PROTO_GENERATED)
178178
cd sdks/python && uv run python -m pytest --snapshot-update
179179

180180
test-julia: $(JL_PARSER) $(JL_PROTO_GENERATED)
181-
cd sdks/julia && julia --project=LogicalQueryProtocol -e 'using Pkg; Pkg.test()'
181+
cd sdks/julia && julia --project=LogicalQueryProtocol.jl -e 'using Pkg; Pkg.test()'
182182

183183
test-go: $(GO_PARSER) $(GO_PROTO_GENERATED)
184184
cd sdks/go && go test ./test/...

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ package to PyPI. To release a new version:
7878

7979
1. Make sure that everything is up-to-date by running `make`.
8080
2. File a PR that updates the version in `sdks/python/pyproject.toml` and
81-
`sdks/julia/LogicalQueryProtocol/Project.toml`. Note that the Go SDK version is
81+
`sdks/julia/LogicalQueryProtocol.jl/Project.toml`. Note that the Go SDK version is
8282
automatically determined by the release tag in GitHub.
8383
3. Get approval and merge into `main`.
8484
4. Create a new GitHub release from `main` with a tag matching the version (e.g.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
MIT License
2+
3+
Copyright (c) 2025 RelationalAI, and contributors
4+
5+
Permission is hereby granted, free of charge, to any person obtaining a copy
6+
of this software and associated documentation files (the "Software"), to deal
7+
in the Software without restriction, including without limitation the rights
8+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9+
copies of the Software, and to permit persons to whom the Software is
10+
furnished to do so, subject to the following conditions:
11+
12+
The above copyright notice and this permission notice shall be included in all
13+
copies or substantial portions of the Software.
14+
15+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21+
SOFTWARE.

sdks/julia/LogicalQueryProtocol/Manifest.toml renamed to sdks/julia/LogicalQueryProtocol.jl/Manifest.toml

Lines changed: 2 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
File renamed without changes.

sdks/julia/LogicalQueryProtocol/src/LogicalQueryProtocol.jl renamed to sdks/julia/LogicalQueryProtocol.jl/src/LogicalQueryProtocol.jl

File renamed without changes.
File renamed without changes.

sdks/julia/LogicalQueryProtocol/src/gen/relationalai/lqp/lqp.jl renamed to sdks/julia/LogicalQueryProtocol.jl/src/gen/relationalai/lqp/lqp.jl

File renamed without changes.

0 commit comments

Comments
 (0)