Commit 5b2feed
Model TargetRelations CDC/non-CDC modes with a oneof
Replace the flat relations/inserts/deletes fields on TargetRelations
with a `oneof body { PlainTargets plain; CdcTargets cdc; }`, making the
mutually-exclusive plain (non-CDC) and CDC modes explicit instead of
inferred from which repeated field happens to be populated. PlainTargets
wraps `targets`; CdcTargets wraps `inserts`/`deletes` (oneof can't hold
repeated fields directly, hence the wrapper messages).
The LQP s-expression syntax is unchanged — only the grammar's
construct/deconstruct helpers and the deconstruct guard (now switching on
the oneof case via has_proto_field) change, so pretty/pretty_debug
snapshots are untouched; only .bin wire encodings shift. Regenerated all
three SDKs; updated hand-written Julia equality (PlainTargets/CdcTargets
+ oneof-based TargetRelations), properties global_ids, and equality
tests. All Python/Go/Julia suites pass.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent 0c3cc76 commit 5b2feed
19 files changed
Lines changed: 1479 additions & 1007 deletions
File tree
- meta/src/meta
- proto/relationalai/lqp/v1
- sdks
- go/src
- lqp/v1
- julia/LogicalQueryProtocol.jl
- src
- gen/relationalai/lqp/v1
- test
- python/src/lqp
- gen
- proto/v1
- tests/bin
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1153 | 1153 | | |
1154 | 1154 | | |
1155 | 1155 | | |
1156 | | - | |
1157 | | - | |
| 1156 | + | |
| 1157 | + | |
1158 | 1158 | | |
1159 | 1159 | | |
1160 | | - | |
1161 | | - | |
1162 | | - | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
1163 | 1163 | | |
1164 | 1164 | | |
1165 | 1165 | | |
| |||
1527 | 1527 | | |
1528 | 1528 | | |
1529 | 1529 | | |
1530 | | - | |
| 1530 | + | |
1531 | 1531 | | |
1532 | 1532 | | |
1533 | 1533 | | |
1534 | | - | |
1535 | | - | |
1536 | | - | |
| 1534 | + | |
1537 | 1535 | | |
1538 | 1536 | | |
1539 | 1537 | | |
| |||
1543 | 1541 | | |
1544 | 1542 | | |
1545 | 1543 | | |
1546 | | - | |
1547 | | - | |
1548 | | - | |
| 1544 | + | |
1549 | 1545 | | |
1550 | 1546 | | |
1551 | 1547 | | |
1552 | 1548 | | |
1553 | 1549 | | |
1554 | 1550 | | |
1555 | 1551 | | |
1556 | | - | |
1557 | | - | |
1558 | | - | |
1559 | | - | |
1560 | | - | |
1561 | | - | |
| 1552 | + | |
| 1553 | + | |
| 1554 | + | |
1562 | 1555 | | |
1563 | 1556 | | |
1564 | 1557 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
301 | 301 | | |
302 | 302 | | |
303 | 303 | | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
308 | 317 | | |
309 | | - | |
310 | | - | |
311 | | - | |
312 | | - | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
313 | 323 | | |
314 | 324 | | |
315 | 325 | | |
| |||
0 commit comments