Skip to content

Commit 5bf6aa8

Browse files
hbarthelsclaude
andcommitted
Drop METADATA$KEY special-casing from LQP comments
On the LQP side a key column name is just a string — there is no special handling of METADATA$KEY (the row-hash derivation happens downstream in the loader). Remove the "special name METADATA$KEY => derived hash" wording from the NamedColumn.name and TargetRelations.keys proto comments (regenerated the Go binding), and reword the analogous comment in the relations_cdc fixture. The METADATA$KEY column-name strings in fixtures are real data and stay. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 1b0b13c commit 5bf6aa8

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

proto/relationalai/lqp/v1/logic.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ message StorageIntegration {
291291
// A single named column with its type. Used to describe both shared key columns and
292292
// per-relation value columns in the generalized `TargetRelations` loading construct.
293293
message NamedColumn {
294-
string name = 1; // Column name (e.g. "src"); special name "METADATA$KEY" => derived hash
294+
string name = 1; // Column name (e.g. "src")
295295
Type type = 2; // Column type
296296
}
297297

@@ -315,7 +315,7 @@ message CDCTargets {
315315
// Generalized loading: shared key columns plus the target relations, loaded either as a
316316
// plain snapshot or as CDC insert/delete deltas. The two modes are mutually exclusive.
317317
message TargetRelations {
318-
repeated NamedColumn keys = 1; // Shared key columns (name "METADATA$KEY" => derived hash)
318+
repeated NamedColumn keys = 1; // Shared key columns
319319
oneof body {
320320
PlainTargets plain = 2;
321321
CDCTargets cdc = 3;

sdks/go/src/lqp/v1/logic.pb.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/lqp/relations_cdc.lqp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
(define
55
(fragment :f1
66
;; Generalized CSV loading with CDC: a single `edge` relation grouped into insert
7-
;; and delete deltas. The shared key is the special METADATA$KEY (a UINT128 hash
8-
;; derived from the CSV's METADATA$ROW_ID column).
7+
;; and delete deltas under a shared UINT128 key column.
98
(csv_data
109
(csv_locator
1110
(paths "s3://bucket/edges.csv"))

0 commit comments

Comments
 (0)