Skip to content

Commit 804eb56

Browse files
committed
update protos based on comments
1 parent 47e53a0 commit 804eb56

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

proto/relationalai/lqp/v1/logic.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ message CSVConfig {
316316

317317
message IcebergData {
318318
IcebergLocator locator = 1;
319-
IcebergConfig config = 2;
319+
IcebergCatalogConfig config = 2;
320320
repeated GNFColumn columns = 3;
321321
optional string to_snapshot = 4;
322322
}
@@ -327,7 +327,7 @@ message IcebergLocator {
327327
string warehouse = 3;
328328
}
329329

330-
message IcebergConfig {
330+
message IcebergCatalogConfig {
331331
string catalog_uri = 1;
332332
optional string scope = 2;
333333
map<string, string> properties = 3;

proto/relationalai/lqp/v1/transactions.proto

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,16 +120,18 @@ message ExportCSVSource {
120120

121121
message ExportIcebergConfig {
122122
IcebergLocator locator = 1;
123-
IcebergConfig config = 2;
124-
repeated IcebergExportColumn columns = 3;
123+
IcebergCatalogConfig config = 2;
124+
repeated ExportIcebergColumn columns = 3;
125125
optional string prefix = 4; // Default: "data"
126126
optional int64 target_file_size_bytes = 5; // Default: 512 MB
127127
string compression = 6; // UNCOMPRESSED, SNAPPY, GZIP, LZ4, ZSTD
128+
map<string, string> create_table_properties = 7; // properties for table creation
128129
}
129130

130-
message IcebergExportColumn {
131+
message ExportIcebergColumn {
131132
string name = 1;
132-
Type type = 2;
133+
RelationId column_data = 2;
134+
Type type = 3;
133135
bool nullable = 3;
134136
}
135137

0 commit comments

Comments
 (0)