Skip to content

Commit 840204b

Browse files
hbarthelsclaude
andcommitted
Make relations_cdc fixture names consistent
Align the CDC relations fixture with the rest of the edge-themed suite: use s3://bucket/edges.csv (matching relations_edge_binary / relations_edge_arity4) and rename the delta relations to :weight_ins / :weight_del, since they carry a weight column. Regenerated the .bin and pretty/pretty_debug snapshot goldens (name-derived relation hashes updated accordingly). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 3335293 commit 840204b

4 files changed

Lines changed: 17 additions & 18 deletions

File tree

tests/bin/relations_cdc.bin

-6 Bytes
Binary file not shown.

tests/lqp/relations_cdc.lqp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,21 @@
88
;; derived from the CSV's METADATA$ROW_ID column).
99
(csv_data
1010
(csv_locator
11-
(paths "s3://bucket/cdc/edges_batch_001.csv"))
11+
(paths "s3://bucket/edges.csv"))
1212
(csv_config {})
1313
;; Insert and delete deltas must target DISTINCT relations (like the legacy
14-
;; columnar loader): a row's METADATA$ACTION routes it to :edge_ins or :edge_del.
14+
;; columnar loader): a row's METADATA$ACTION routes it to :weight_ins or :weight_del.
1515
(relations
1616
(keys
1717
(column "METADATA$KEY" UINT128))
1818
(inserts
19-
(relation :edge_ins
19+
(relation :weight_ins
2020
(column "weight" FLOAT)))
2121
(deletes
22-
(relation :edge_del
22+
(relation :weight_del
2323
(column "weight" FLOAT))))
2424
(asof "2025-06-01T00:00:00Z")))))
2525

2626
(reads
27-
(output :edge_ins :edge_ins)
28-
(output :edge_del :edge_del))))
27+
(output :weight_ins :weight_ins)
28+
(output :weight_del :weight_del))))

tests/pretty/relations_cdc.lqp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
(fragment
77
:f1
88
(csv_data
9-
(csv_locator (paths "s3://bucket/cdc/edges_batch_001.csv"))
9+
(csv_locator (paths "s3://bucket/edges.csv"))
1010
(csv_config
1111
{
1212
:csv_compression "auto"
@@ -19,7 +19,7 @@
1919
:csv_skip 0})
2020
(relations
2121
(keys (column "METADATA$KEY" UINT128))
22-
(inserts (relation :edge_ins (column "weight" FLOAT))) (deletes
23-
(relation :edge_del (column "weight" FLOAT))))
22+
(inserts (relation :weight_ins (column "weight" FLOAT))) (deletes
23+
(relation :weight_del (column "weight" FLOAT))))
2424
(asof "2025-06-01T00:00:00Z")))))
25-
(reads (output :edge_ins :edge_ins) (output :edge_del :edge_del))))
25+
(reads (output :weight_ins :weight_ins) (output :weight_del :weight_del))))

tests/pretty_debug/relations_cdc.lqp

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
(fragment
77
:f1
88
(csv_data
9-
(csv_locator (paths "s3://bucket/cdc/edges_batch_001.csv"))
9+
(csv_locator (paths "s3://bucket/edges.csv"))
1010
(csv_config
1111
{
1212
:csv_compression "auto"
@@ -19,16 +19,15 @@
1919
:csv_skip 0})
2020
(relations
2121
(keys (column "METADATA$KEY" UINT128))
22-
(inserts
23-
(relation 0x6c9225cf3609ca4d26168fd6652e0d03 (column "weight" FLOAT))) (deletes
24-
(relation 0x5ef875f96a25ff5f076bea0e815c6ce0 (column "weight" FLOAT))))
22+
(inserts (relation 0x678037975b01b6389c78bc1cc79abde (column "weight" FLOAT))) (deletes
23+
(relation 0xb214f85adaa2e403bed30d3721f4363 (column "weight" FLOAT))))
2524
(asof "2025-06-01T00:00:00Z")))))
2625
(reads
27-
(output :edge_ins 0x6c9225cf3609ca4d26168fd6652e0d03)
28-
(output :edge_del 0x5ef875f96a25ff5f076bea0e815c6ce0))))
26+
(output :weight_ins 0x678037975b01b6389c78bc1cc79abde)
27+
(output :weight_del 0xb214f85adaa2e403bed30d3721f4363))))
2928

3029
;; Debug information
3130
;; -----------------------
3231
;; Original names
33-
;; ID `0x5ef875f96a25ff5f076bea0e815c6ce0` -> `edge_del`
34-
;; ID `0x6c9225cf3609ca4d26168fd6652e0d03` -> `edge_ins`
32+
;; ID `0xb214f85adaa2e403bed30d3721f4363` -> `weight_del`
33+
;; ID `0x678037975b01b6389c78bc1cc79abde` -> `weight_ins`

0 commit comments

Comments
 (0)