Skip to content

Commit 9a8b7e3

Browse files
authored
fix IcebergData global_ids (#239)
1 parent df3fb2f commit 9a8b7e3

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

sdks/julia/LogicalQueryProtocol.jl/src/properties.jl

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,12 +149,21 @@ function global_ids(data::Data)
149149
end
150150
end
151151
return ids
152+
elseif dt.name == :iceberg_data
153+
iceberg_data = dt[]::IcebergData
154+
ids = LQPRelationId[]
155+
for column in iceberg_data.columns
156+
if !isnothing(column.target_id)
157+
push!(ids, persistent_id(column.target_id))
158+
end
159+
end
160+
return ids
152161
else
153162
@assert _is_valid_data(data)
154163
end
155164
end
156165

157166
function _is_valid_data(data::Data)
158167
dt = data.data_type
159-
return !isnothing(dt) && dt.name in [:edb, :betree_relation, :csv_data]
168+
return !isnothing(dt) && dt.name in [:edb, :betree_relation, :csv_data, :iceberg_data]
160169
end

sdks/julia/LogicalQueryProtocol.jl/test/jet_test.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@
1717
# At runtime, the preceding `_has_proto_field` guard ensures correctness.
1818
function is_oneof_field_false_positive(report)
1919
msg = sprint(show, report)
20-
return occursin("has no field args", msg) || occursin("has no field scale", msg)
20+
return occursin("has no field args", msg) || occursin("has no field scale", msg) ||
21+
occursin("has no field data_columns", msg)
2122
end
2223

2324
# Filter BoundsError false positives from array internals in generated code.

0 commit comments

Comments
 (0)