update snapshots, fix julia errors (hopefully)

Author: vustef

meta/src/meta/grammar.y

@@ -1182,7 +1182,7 @@ iceberg_to_snapshot
 
 iceberg_data
     : "(" "iceberg_data" iceberg_locator iceberg_config gnf_columns iceberg_to_snapshot? ")"
-      construct: $$ = logic.IcebergData(locator=$3, config=$4, columns=$5, to_snapshot=$6)
+      construct: $$ = logic.IcebergData(locator=$3, config=$4, columns=$5, to_snapshot=builtin.some(builtin.unwrap_option_or($6, "")))
       deconstruct:
         $3: logic.IcebergLocator = $$.locator
         $4: logic.IcebergConfig = $$.config
@@ -1645,20 +1645,20 @@ def construct_iceberg_config(
     auth_props: Dict[String, String] = builtin.string_map_from_pairs(auth_property_pairs)
     return logic.IcebergConfig(
         catalog_uri=catalog_uri,
-        scope=scope_opt,
+        scope=builtin.some(builtin.unwrap_option_or(scope_opt, "")),
         properties=props,
         auth_properties=auth_props,
     )
 
 
 def deconstruct_iceberg_config_scope_optional(msg: logic.IcebergConfig) -> Optional[String]:
-    if builtin.has_proto_field(msg, "scope"):
+    if builtin.unwrap_option(msg.scope) != "":
         return builtin.some(builtin.unwrap_option(msg.scope))
     return builtin.none()
 
 
 def deconstruct_iceberg_data_to_snapshot_optional(msg: logic.IcebergData) -> Optional[String]:
-    if builtin.has_proto_field(msg, "to_snapshot"):
+    if builtin.unwrap_option(msg.to_snapshot) != "":
         return builtin.some(builtin.unwrap_option(msg.to_snapshot))
     return builtin.none()
 

sdks/go/src/parser.go

@@ -858,7 +858,7 @@ func (p *Parser) construct_export_csv_config_with_source(path string, csv_source
 func (p *Parser) construct_iceberg_config(catalog_uri string, scope_opt *string, property_pairs [][]interface{}, auth_property_pairs [][]interface{}) *pb.IcebergConfig {
 	props := stringMapFromPairs(property_pairs)
 	auth_props := stringMapFromPairs(auth_property_pairs)
-	_t2097 := &pb.IcebergConfig{CatalogUri: catalog_uri, Scope: scope_opt, Properties: props, AuthProperties: auth_props}
+	_t2097 := &pb.IcebergConfig{CatalogUri: catalog_uri, Scope: ptr(deref(scope_opt, "")), Properties: props, AuthProperties: auth_props}
 	return _t2097
 }
 
@@ -4378,7 +4378,7 @@ func (p *Parser) parse_iceberg_data() *pb.IcebergData {
 	}
 	iceberg_to_snapshot1184 := _t1953
 	p.consumeLiteral(")")
-	_t1955 := &pb.IcebergData{Locator: iceberg_locator1181, Config: iceberg_config1182, Columns: gnf_columns1183, ToSnapshot: iceberg_to_snapshot1184}
+	_t1955 := &pb.IcebergData{Locator: iceberg_locator1181, Config: iceberg_config1182, Columns: gnf_columns1183, ToSnapshot: ptr(deref(iceberg_to_snapshot1184, ""))}
 	result1186 := _t1955
 	p.recordSpan(int(span_start1185), "IcebergData")
 	return result1186

sdks/julia/LogicalQueryProtocol.jl/src/parser.jl

@@ -567,7 +567,7 @@ end
 function construct_iceberg_config(parser::ParserState, catalog_uri::String, scope_opt::Union{Nothing, String}, property_pairs::Vector{Tuple{String, String}}, auth_property_pairs::Vector{Tuple{String, String}})::Proto.IcebergConfig
     props = Dict(property_pairs)
     auth_props = Dict(auth_property_pairs)
-    _t2086 = Proto.IcebergConfig(catalog_uri=catalog_uri, scope=scope_opt, properties=props, auth_properties=auth_props)
+    _t2086 = Proto.IcebergConfig(catalog_uri=catalog_uri, scope=(!isnothing(scope_opt) ? scope_opt : ""), properties=props, auth_properties=auth_props)
     return _t2086
 end
 
@@ -3706,7 +3706,7 @@ function parse_iceberg_data(parser::ParserState)::Proto.IcebergData
     end
     iceberg_to_snapshot1184 = _t1942
     consume_literal!(parser, ")")
-    _t1944 = Proto.IcebergData(locator=iceberg_locator1181, config=iceberg_config1182, columns=gnf_columns1183, to_snapshot=iceberg_to_snapshot1184)
+    _t1944 = Proto.IcebergData(locator=iceberg_locator1181, config=iceberg_config1182, columns=gnf_columns1183, to_snapshot=(!isnothing(iceberg_to_snapshot1184) ? iceberg_to_snapshot1184 : ""))
     result1186 = _t1944
     record_span!(parser, span_start1185, "IcebergData")
     return result1186

sdks/python/src/lqp/gen/parser.py

@@ -646,7 +646,7 @@ def construct_export_csv_config_with_source(self, path: str, csv_source: transac
     def construct_iceberg_config(self, catalog_uri: str, scope_opt: str | None, property_pairs: Sequence[tuple[str, str]], auth_property_pairs: Sequence[tuple[str, str]]) -> logic_pb2.IcebergConfig:
         props = dict(property_pairs)
         auth_props = dict(auth_property_pairs)
-        _t2095 = logic_pb2.IcebergConfig(catalog_uri=catalog_uri, scope=scope_opt, properties=props, auth_properties=auth_props)
+        _t2095 = logic_pb2.IcebergConfig(catalog_uri=catalog_uri, scope=(scope_opt if scope_opt is not None else ""), properties=props, auth_properties=auth_props)
         return _t2095
 
     def construct_export_iceberg_config_full(self, locator: logic_pb2.IcebergLocator, config: logic_pb2.IcebergConfig, columns: Sequence[transactions_pb2.IcebergExportColumn], config_dict: Sequence[tuple[str, logic_pb2.Value]] | None) -> transactions_pb2.ExportIcebergConfig:
@@ -3385,7 +3385,7 @@ def parse_iceberg_data(self) -> logic_pb2.IcebergData:
             _t1942 = None
         iceberg_to_snapshot1184 = _t1942
         self.consume_literal(")")
-        _t1944 = logic_pb2.IcebergData(locator=iceberg_locator1181, config=iceberg_config1182, columns=gnf_columns1183, to_snapshot=iceberg_to_snapshot1184)
+        _t1944 = logic_pb2.IcebergData(locator=iceberg_locator1181, config=iceberg_config1182, columns=gnf_columns1183, to_snapshot=(iceberg_to_snapshot1184 if iceberg_to_snapshot1184 is not None else ""))
         result1186 = _t1944
         self.record_span(span_start1185, "IcebergData")
         return result1186

tests/bin/iceberg_data.bin

@@ -21,6 +21,7 @@
         (
         catalog_uri
         "https://catalog.example")
+      (scope "")
       (
       properties
       (prop "type" "rest"))

tests/bin/iceberg_export.bin

@@ -29,6 +29,7 @@
       (
       catalog_uri
       "https://catalog.example.com")
+    (scope "")
     (
     properties)
   (
@@ -83,6 +84,7 @@ columns
   (
   catalog_uri
   "https://catalog.example.com")
+(scope "")
 (
 properties)
 (

tests/pretty/iceberg_data.lqp

@@ -21,6 +21,7 @@
         (
         catalog_uri
         "https://catalog.example")
+      (scope "")
       (
       properties
       (prop "type" "rest"))

tests/pretty/iceberg_export.lqp

@@ -29,6 +29,7 @@
       (
       catalog_uri
       "https://catalog.example.com")
+    (scope "")
     (
     properties)
   (
@@ -83,6 +84,7 @@ columns
   (
   catalog_uri
   "https://catalog.example.com")
+(scope "")
 (
 properties)
 (