Skip to content

Commit db90027

Browse files
authored
Fix Go SDK setup (#214)
1 parent 8b8218b commit db90027

12 files changed

Lines changed: 21 additions & 14 deletions

File tree

README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,13 @@ package to PyPI. To release a new version:
8484
4. Create a new GitHub release from `main` with a tag matching the version (e.g.
8585
`gh release create v0.3.0 --title "v0.3.0" --generate-notes`). The release must be
8686
created after merging the version bump, since the workflow checks out the default branch.
87+
5. Tag the release for the Go submodule. Go requires a separate tag with the subdirectory
88+
prefix for modules that live outside the repository root:
89+
```bash
90+
git tag sdks/go/v0.3.0 v0.3.0
91+
git push origin sdks/go/v0.3.0
92+
```
93+
Without this tag, `go get` will not be able to resolve the module at the released version.
8794

8895
To publish manually instead:
8996

meta/src/meta/templates/parser.go.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import (
1818
"strconv"
1919
"strings"
2020

21-
pb "logical-query-protocol/src/lqp/v1"
21+
pb "github.com/RelationalAI/logical-query-protocol/sdks/go/src/lqp/v1"
2222
"google.golang.org/protobuf/reflect/protoreflect"
2323
)
2424

meta/src/meta/templates/pretty_printer.go.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import (
1616
"sort"
1717
"strings"
1818

19-
pb "logical-query-protocol/src/lqp/v1"
19+
pb "github.com/RelationalAI/logical-query-protocol/sdks/go/src/lqp/v1"
2020
)
2121

2222
const maxWidth = 92

proto/relationalai/lqp/v1/fragments.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
syntax = "proto3";
22

3-
option go_package = "logical-query-protocol/lqp/v1";
3+
option go_package = "github.com/RelationalAI/logical-query-protocol/sdks/go/src/lqp/v1";
44

55
package relationalai.lqp.v1;
66

proto/relationalai/lqp/v1/logic.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
syntax = "proto3";
22

3-
option go_package = "logical-query-protocol/lqp/v1";
3+
option go_package = "github.com/RelationalAI/logical-query-protocol/sdks/go/src/lqp/v1";
44

55
package relationalai.lqp.v1;
66

proto/relationalai/lqp/v1/transactions.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
syntax = "proto3";
22

3-
option go_package = "logical-query-protocol/lqp/v1";
3+
option go_package = "github.com/RelationalAI/logical-query-protocol/sdks/go/src/lqp/v1";
44

55
package relationalai.lqp.v1;
66

sdks/go/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
module logical-query-protocol
1+
module github.com/RelationalAI/logical-query-protocol/sdks/go
22

33
go 1.25.4
44

sdks/go/src/parser.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import (
1818
"strconv"
1919
"strings"
2020

21-
pb "logical-query-protocol/src/lqp/v1"
21+
pb "github.com/RelationalAI/logical-query-protocol/sdks/go/src/lqp/v1"
2222
"google.golang.org/protobuf/reflect/protoreflect"
2323
)
2424

sdks/go/src/pretty.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import (
1616
"sort"
1717
"strings"
1818

19-
pb "logical-query-protocol/src/lqp/v1"
19+
pb "github.com/RelationalAI/logical-query-protocol/sdks/go/src/lqp/v1"
2020
)
2121

2222
const maxWidth = 92

sdks/go/test/extra_print_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ package test
33
import (
44
"testing"
55

6-
lqp "logical-query-protocol/src"
7-
pb "logical-query-protocol/src/lqp/v1"
6+
lqp "github.com/RelationalAI/logical-query-protocol/sdks/go/src"
7+
pb "github.com/RelationalAI/logical-query-protocol/sdks/go/src/lqp/v1"
88
)
99

1010
// ---------------------------------------------------------------------------

0 commit comments

Comments
 (0)