fix go test

Author: vustef

meta/src/meta/grammar.y

@@ -1182,7 +1182,7 @@ iceberg_to_snapshot
 
 iceberg_data
     : "(" "iceberg_data" iceberg_locator iceberg_config gnf_columns iceberg_to_snapshot? ")"
-      construct: $$ = logic.IcebergData(locator=$3, config=$4, columns=$5, to_snapshot=builtin.unwrap_option_or($6, ""))
+      construct: $$ = logic.IcebergData(locator=$3, config=$4, columns=$5, to_snapshot=$6)
       deconstruct:
         $3: logic.IcebergLocator = $$.locator
         $4: logic.IcebergConfig = $$.config
@@ -1643,10 +1643,9 @@ def construct_iceberg_config(
 ) -> logic.IcebergConfig:
     props: Dict[String, String] = builtin.string_map_from_pairs(property_pairs)
     auth_props: Dict[String, String] = builtin.string_map_from_pairs(auth_property_pairs)
-    scope_pb: String = builtin.unwrap_option_or(scope_opt, "")
     return logic.IcebergConfig(
         catalog_uri=catalog_uri,
-        scope=scope_pb,
+        scope=scope_opt,
         properties=props,
         auth_properties=auth_props,
     )

meta/src/meta/grammar_validator.py

@@ -62,17 +62,6 @@
 from .validation_result import ValidationResult
 
 
-def _optional_string_allows_plain_string(
-    actual: TargetType, expected: TargetType
-) -> bool:
-    """True if actual is String and expected is Option[String] (optional proto string)."""
-    if isinstance(expected, OptionType) and isinstance(expected.element_type, BaseType):
-        if expected.element_type.name != "String":
-            return False
-        return isinstance(actual, BaseType) and actual.name == "String"
-    return False
-
-
 class GrammarValidator:
     """Validates grammar against protobuf specification."""
 
@@ -282,17 +271,12 @@ def _check_new_message_types(self, new_msg: NewMessage, context: str) -> None:
 
             # Check actual type is a subtype of expected type (actual_type <: expected_type)
             if actual_type is not None and not is_subtype(actual_type, expected_type):
-                # Optional proto string fields are often represented as plain String at runtime
-                # (e.g. ProtoBuf.jl uses "" for unset); allow String where Option[String] is expected.
-                if _optional_string_allows_plain_string(actual_type, expected_type):
-                    pass
-                else:
-                    self.result.add_error(
-                        "field_type",
-                        f"In {context}: NewMessage {new_msg.name} field '{field_name}' has type {actual_type}, expected {expected_type}",
-                        proto_type=new_msg.name,
-                        rule_name=context,
-                    )
+                self.result.add_error(
+                    "field_type",
+                    f"In {context}: NewMessage {new_msg.name} field '{field_name}' has type {actual_type}, expected {expected_type}",
+                    proto_type=new_msg.name,
+                    rule_name=context,
+                )
 
         # Check for missing fields
         for field in proto_message.fields:

sdks/go/src/parser.go

@@ -858,8 +858,7 @@ func (p *Parser) construct_export_csv_config_with_source(path string, csv_source
 func (p *Parser) construct_iceberg_config(catalog_uri string, scope_opt *string, property_pairs [][]interface{}, auth_property_pairs [][]interface{}) *pb.IcebergConfig {
 	props := stringMapFromPairs(property_pairs)
 	auth_props := stringMapFromPairs(auth_property_pairs)
-	scope_pb := deref(scope_opt, "")
-	_t2097 := &pb.IcebergConfig{CatalogUri: catalog_uri, Scope: scope_pb, Properties: props, AuthProperties: auth_props}
+	_t2097 := &pb.IcebergConfig{CatalogUri: catalog_uri, Scope: scope_opt, Properties: props, AuthProperties: auth_props}
 	return _t2097
 }
 
@@ -4380,7 +4379,7 @@ func (p *Parser) parse_iceberg_data() *pb.IcebergData {
 	}
 	iceberg_to_snapshot1184 := _t1953
 	p.consumeLiteral(")")
-	_t1955 := &pb.IcebergData{Locator: iceberg_locator1181, Config: iceberg_config1182, Columns: gnf_columns1183, ToSnapshot: ptr(deref(iceberg_to_snapshot1184, ""))}
+	_t1955 := &pb.IcebergData{Locator: iceberg_locator1181, Config: iceberg_config1182, Columns: gnf_columns1183, ToSnapshot: iceberg_to_snapshot1184}
 	result1186 := _t1955
 	p.recordSpan(int(span_start1185), "IcebergData")
 	return result1186

sdks/julia/LogicalQueryProtocol.jl/src/parser.jl

@@ -567,8 +567,7 @@ end
 function construct_iceberg_config(parser::ParserState, catalog_uri::String, scope_opt::Union{Nothing, String}, property_pairs::Vector{Tuple{String, String}}, auth_property_pairs::Vector{Tuple{String, String}})::Proto.IcebergConfig
     props = Dict(property_pairs)
     auth_props = Dict(auth_property_pairs)
-    scope_pb = (!isnothing(scope_opt) ? scope_opt : "")
-    _t2086 = Proto.IcebergConfig(catalog_uri=catalog_uri, scope=scope_pb, properties=props, auth_properties=auth_props)
+    _t2086 = Proto.IcebergConfig(catalog_uri=catalog_uri, scope=scope_opt, properties=props, auth_properties=auth_props)
     return _t2086
 end
 
@@ -3712,7 +3711,7 @@ function parse_iceberg_data(parser::ParserState)::Proto.IcebergData
     end
     iceberg_to_snapshot1184 = _t1942
     consume_literal!(parser, ")")
-    _t1944 = Proto.IcebergData(locator=iceberg_locator1181, config=iceberg_config1182, columns=gnf_columns1183, to_snapshot=(!isnothing(iceberg_to_snapshot1184) ? iceberg_to_snapshot1184 : ""))
+    _t1944 = Proto.IcebergData(locator=iceberg_locator1181, config=iceberg_config1182, columns=gnf_columns1183, to_snapshot=iceberg_to_snapshot1184)
     result1186 = _t1944
     record_span!(parser, span_start1185, "IcebergData")
     return result1186

sdks/python/src/lqp/gen/parser.py

@@ -646,8 +646,7 @@ def construct_export_csv_config_with_source(self, path: str, csv_source: transac
     def construct_iceberg_config(self, catalog_uri: str, scope_opt: str | None, property_pairs: Sequence[tuple[str, str]], auth_property_pairs: Sequence[tuple[str, str]]) -> logic_pb2.IcebergConfig:
         props = dict(property_pairs)
         auth_props = dict(auth_property_pairs)
-        scope_pb = (scope_opt if scope_opt is not None else "")
-        _t2095 = logic_pb2.IcebergConfig(catalog_uri=catalog_uri, scope=scope_pb, properties=props, auth_properties=auth_props)
+        _t2095 = logic_pb2.IcebergConfig(catalog_uri=catalog_uri, scope=scope_opt, properties=props, auth_properties=auth_props)
         return _t2095
 
     def construct_export_iceberg_config_full(self, locator: logic_pb2.IcebergLocator, config: logic_pb2.IcebergConfig, columns: Sequence[transactions_pb2.IcebergExportColumn], config_dict: Sequence[tuple[str, logic_pb2.Value]] | None) -> transactions_pb2.ExportIcebergConfig:
@@ -3391,7 +3390,7 @@ def parse_iceberg_data(self) -> logic_pb2.IcebergData:
             _t1942 = None
         iceberg_to_snapshot1184 = _t1942
         self.consume_literal(")")
-        _t1944 = logic_pb2.IcebergData(locator=iceberg_locator1181, config=iceberg_config1182, columns=gnf_columns1183, to_snapshot=(iceberg_to_snapshot1184 if iceberg_to_snapshot1184 is not None else ""))
+        _t1944 = logic_pb2.IcebergData(locator=iceberg_locator1181, config=iceberg_config1182, columns=gnf_columns1183, to_snapshot=iceberg_to_snapshot1184)
         result1186 = _t1944
         self.record_span(span_start1185, "IcebergData")
         return result1186