Skip to content

Commit ee10a12

Browse files
authored
Fix default value for CSV compression option (#258)
* Fix default csv compression value * Update generated parsers * Update test snapshots
1 parent 00da0f1 commit ee10a12

22 files changed

Lines changed: 46 additions & 46 deletions

meta/src/meta/grammar.y

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1488,7 +1488,7 @@ def construct_csv_config(
14881488
missing_strings: Sequence[String] = _extract_value_string_list(builtin.dict_get(config, "csv_missing_strings"), list[str]())
14891489
decimal_separator: str = _extract_value_string(builtin.dict_get(config, "csv_decimal_separator"), ".")
14901490
encoding: str = _extract_value_string(builtin.dict_get(config, "csv_encoding"), "utf-8")
1491-
compression: str = _extract_value_string(builtin.dict_get(config, "csv_compression"), "auto")
1491+
compression: str = _extract_value_string(builtin.dict_get(config, "csv_compression"), "")
14921492
partition_size_mb: int = _extract_value_int64(builtin.dict_get(config, "csv_partition_size_mb"), 0)
14931493
storage_integration: Optional[logic.StorageIntegration] = construct_csv_storage_integration(storage_integration_opt)
14941494
return logic.CSVConfig(

sdks/go/src/parser.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -757,7 +757,7 @@ func (p *Parser) construct_csv_config(config_dict [][]interface{}, storage_integ
757757
decimal_separator := _t2118
758758
_t2119 := p._extract_value_string(dictGetValue(config, "csv_encoding"), "utf-8")
759759
encoding := _t2119
760-
_t2120 := p._extract_value_string(dictGetValue(config, "csv_compression"), "auto")
760+
_t2120 := p._extract_value_string(dictGetValue(config, "csv_compression"), "")
761761
compression := _t2120
762762
_t2121 := p._extract_value_int64(dictGetValue(config, "csv_partition_size_mb"), 0)
763763
partition_size_mb := _t2121

sdks/julia/LogicalQueryProtocol.jl/src/parser.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ function construct_csv_config(parser::ParserState, config_dict::Vector{Tuple{Str
471471
decimal_separator = _t2105
472472
_t2106 = _extract_value_string(parser, get(config, "csv_encoding", nothing), "utf-8")
473473
encoding = _t2106
474-
_t2107 = _extract_value_string(parser, get(config, "csv_compression", nothing), "auto")
474+
_t2107 = _extract_value_string(parser, get(config, "csv_compression", nothing), "")
475475
compression = _t2107
476476
_t2108 = _extract_value_int64(parser, get(config, "csv_partition_size_mb", nothing), 0)
477477
partition_size_mb = _t2108

sdks/python/src/lqp/gen/parser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@ def construct_csv_config(self, config_dict: Sequence[tuple[str, logic_pb2.Value]
560560
decimal_separator = _t2114
561561
_t2115 = self._extract_value_string(config.get("csv_encoding"), "utf-8")
562562
encoding = _t2115
563-
_t2116 = self._extract_value_string(config.get("csv_compression"), "auto")
563+
_t2116 = self._extract_value_string(config.get("csv_compression"), "")
564564
compression = _t2116
565565
_t2117 = self._extract_value_int64(config.get("csv_partition_size_mb"), 0)
566566
partition_size_mb = _t2117

tests/bin/cdc.bin

-6 Bytes
Binary file not shown.

tests/bin/csv.bin

-25 Bytes
Binary file not shown.

tests/bin/csv_export_v2.bin

-66 Bytes
Binary file not shown.
-18 Bytes
Binary file not shown.

tests/bin/snapshot.bin

-6 Bytes
Binary file not shown.

tests/bin/unicode.bin

-6 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)