Conversation
nystrom
suggested changes
Mar 5, 2026
nystrom
left a comment
nystrom
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Some minor issues.
| register_builtin("format_int64", [INT64], STRING) | ||
| register_builtin("format_int32", [INT32], STRING) | ||
| register_builtin("format_float32", [FLOAT32], STRING) | ||
| register_builtin("format_int32_literal", [INT32], STRING) |
Contributor
There was a problem hiding this comment.
There's already format_int32. Can we just fix that instead?
Collaborator
Author
nystrom
approved these changes
Mar 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LQP is meant to support the same set of types that Iceberg does. 32-bit integer and float types were missing so far. This PR introduces them as INT32 and FLOAT32.