Skip to content

Make int32 config parsing strict and loud #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hbarthels merged 1 commit into from
Jul 13, 2026
Merged

Make int32 config parsing strict and loud #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions meta/src/meta/grammar.y
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1456,9 +1456,11 @@ export_iceberg_config


def _extract_value_int32(value: Optional[logic.Value], default: int) -> Int32:
if value is not None and builtin.has_proto_field(builtin.unwrap_option(value), 'int32_value'):
if value is None:
return builtin.int64_to_int32(default)
if builtin.has_proto_field(builtin.unwrap_option(value), 'int32_value'):
return builtin.unwrap_option(value).int32_value
return builtin.int64_to_int32(default)
builtin.error("expected an int32 value (e.g. `1i32`) for this config field")


def _extract_value_int64(value: Optional[logic.Value], default: int) -> int:
Expand Down
Loading
Loading