198-Bug improve match history to show pending matchups instead of hiding TBD slots#315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
fetch_ticket_contextto resolve TBD match slots usingentrantSources, showing "Waiting on Match #X [TeamA score - score TeamB]" instead of hiding the entryentirely
entrantSourcesslot lookup to match byentrantIdinstead of positional index, preventing wrong match numbers from being displayed/match-historyto pre-populate TBD team history with the source match chain and live score/match-infoand ticket open embeds to display TBD team name with source match context andScore: Noneget_team_inforeturningNoneinstead of0for unplayed match scoresScreenshots
Match Info:
Match History:
Closes #198