Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/ResearchObject/packaging_data_with_ro-crate/compare/md-outputs..md-outputs-PR-8 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-04-30 13:20:48 +0000 |
douglowe
left a comment
There was a problem hiding this comment.
I think it looks okay. I've noted 2 minor items to address, but otherwise we can merge this I think.
|
|
||
| Licensed under the Apache License, Version 2.0 (the “License”); you may not use this file except in compliance with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
Note the warning from GH actions that this should be in the form text
There was a problem hiding this comment.
ignoring the warning as this block is using the boilerplate taken from How to apply the Apache License to your work
Auto-generated via `{sandpaper}`
Source : cde2890
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-04-30 13:22:02 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 486f9c4
Branch : main
Author : Eli Chadwick <eli.chadwick@manchester.ac.uk>
Time : 2025-04-30 13:21:23 +0000
Message : Merge pull request #8 from ResearchObject/update-config
Update config, README, and contributor docs
Fixes #7 and migrates some of the files that were lost in transition (LICENSE and CONTRIBUTING). For CONTRIBUTING I updated it using the latest version from the Carpentries template: https://github.com/carpentries/workbench-template-md/blob/main/CONTRIBUTING.md.
Also moves the
files/rainfall-1.2.1folder underepisodes/- I think this is necessary forsandpaperto render it. Thero-crate-preview.htmlfile was also lost in transition so I re-created it withrochtml(and copied it toindex.htmlfor good measure).ro-crate-dynamic.jsis no longer needed as it's now hosted somewhere by (I presume) the LDaCA team.