-
Notifications
You must be signed in to change notification settings - Fork 7
Update references to 1.2 spec, re-ordering, content updates #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4a2c63d
Updates for 1.2 and suggestions from ACM run through
a-mile 5654b5e
fix issue causing build to fail, additional 1.1->1.2 updates
a-mile 38084fd
formatting updates, fix typos
a-mile 3a9ca6c
close challenge block, remove white spaces
a-mile c361138
Apply suggestions from code review
a-mile 53480fc
address review comments
a-mile 61f2813
reverted file renaming
a-mile 97adeee
resolve mixed-up filenames
elichad bf2f544
move json comma callout to metadata description section
elichad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| --- | ||
| title: "Contributor Code of Conduct" | ||
| --- | ||
|
|
||
| # Contributor Code of Conduct | ||
|
|
||
| Contributors to the RO-Crate community, including this tutorial, are expected to comply with our [Code of Conduct](https://github.com/ResearchObject/ro-crate/blob/main/CODE_OF_CONDUCT.md) to ensure an open and inclusive environment. You may email conduct@researchobject.org to report any Code of Conduct concerns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| --- | ||
| title: Declaring the root folder | ||
| teaching: 2 | ||
| exercises: 1 | ||
| --- | ||
|
|
||
| :::::::::::::::::::::::::::::::::::::::: questions | ||
| - What is the root folder? | ||
| :::::::::::::::::::::::::::::::::::::::::::::::::: | ||
|
|
||
| :::::::::::::::::::::::::::::::::::::::: objectives | ||
| - Create a top-level entity that can list the parts of the crate | ||
| :::::::::::::::::::::::::::::::::::::::::::::::::: | ||
|
|
||
| ## RO-Crate Root | ||
|
|
||
| First we'll add an entity to the `@graph` array, | ||
| to describe the [RO-Crate Root](https://www.researchobject.org/ro-crate/specification/1.2/root-data-entity.html#direct-properties-of-the-root-data-entity): | ||
|
|
||
| ```json | ||
| { | ||
| "@id": "./", | ||
| "@type": "Dataset", | ||
| "hasPart": [ | ||
|
|
||
| ] | ||
| } | ||
| ``` | ||
|
|
||
| By convention, in RO-Crate the `@id` value of `./` means that this entity describes the folder in which the RO-Crate metadata file is located. The root data entity always has the `@type` value of `Dataset`, which is a [schema.org](https://schema.org/Dataset) type. | ||
| This will be referenced from `ro-crate-metadata.json`, semantically marking the `crate1` folder as being the RO-Crate Root. | ||
|
|
||
|
|
||
| :::::::::::::::::::::::::::::::::::::::: discussion | ||
| ## RO-Crates can be published on the Web | ||
|
|
||
| This example is a folder-based RO-Crate stored on disk, | ||
| and therefore absolute paths are avoided, | ||
| e.g. in case the root folder is moved or archived as a ZIP file. | ||
|
|
||
| If the crate is being served from a Web service, | ||
| such as a data repository or database where files are not organized in folders, | ||
| then the `@id` might be an absolute URI instead of `./` | ||
| -- this is one reason why we point to the root entity from the metadata descriptor, | ||
| see section [Root Data Entity](https://www.researchobject.org/ro-crate/specification/1.2/root-data-entity.html) for details. | ||
|
a-mile marked this conversation as resolved.
Outdated
|
||
| :::::::::::::::::::::::::::::::::::::::::::::::::: | ||
|
|
||
| :::::::::::::::::::::::::::::::::::::::: challenge | ||
| ## Add an additional type | ||
|
|
||
| 1. Navigate the schema.org type list to find a subtype of `CreativeWork` that is suitable for a learning resource. | ||
| 2. Modify the root entity's `@type` to be an array. | ||
| 3. Add the type name for learning resource at the end of the array. | ||
|
|
||
| ::::::::::::::: solution | ||
| ```json | ||
| { | ||
| "@id": "./", | ||
| "@type": ["Dataset", "LearningResource"], | ||
| "hasPart": [ | ||
| {"@id": "data.csv"} | ||
| ], | ||
| "…": "…" | ||
| } | ||
| ``` | ||
| ::::::::::::::::::::::::: | ||
| :::::::::::::::::::::::::::::::::::::::::::::::::: | ||
|
|
||
| The root has several metadata properties that describe the RO-Crate as a whole, | ||
| considering it as a Research Object of collected resources. | ||
| The section on [root data entity](https://www.researchobject.org/ro-crate/specification/1.2/root-data-entity.html) | ||
| details further the required and recommended properties of the root `./`. | ||
|
a-mile marked this conversation as resolved.
Outdated
|
||
|
|
||
| :::::::::::::::::::::::::::::::::::::::: keypoints | ||
| - The RO-Crate Root is the top-level object of the RO-Crate | ||
| - The root identifier is commonly just ./ for the current folder, but can be a URL | ||
| - The root is always typed as a Dataset, but can have additional types | ||
| :::::::::::::::::::::::::::::::::::::::::::::::::: | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are changing these file names, we should also set up redirects from the old paths to the new paths - I'm asking the workbench team if this is possible. Otherwise we might want to just leave the filenames alone, but we can still reorder them here (most people won't notice that the URLs are in the wrong order...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking, I can change them back if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alas, it is not possible to do redirects in the same simple way as we do on the RO-Crate website. The Workbench doesn't have any support for custom redirects.
The Workbench team suggested a workaround of including an HTML file specifying the redirect. If that HTML file had the same name as the page that the Workbench would have produced from the old episode file, visitors looking for that old episode would arrive at that page and be redirected to the new location.
However, I think I prefer to just keep the filenames unchanged and just have the numbers out of order (same with 14 and 15). I don't think it's worth adding extra clutter with additional files. If it does cause noticeable issues then we can always rename them in another PR later.