Conversation
…t` param. Update unbag_rocrate to simplify extracting root directory for RO-Crate bag with new internal function .get_zip_root
…MACOSX) and reformat code with use_air()
…ernal function .find_bagit_root to find the root directory of an RO-Crate bag
…irectory and validate the object
… and leave scope for future extra validations
… is_rocrate_bag and load_rocrate_bag can be optional, in which case it will be auto detected
…O-Crate metadata file is a valid JSON file
…e object in load_rocrate_bag
…e with additional details when an RO-Crate is bagged
…BagIt archives, flat RO-Crates (metadata file) and directories containing RO-Crates
…imum number of lines to be displayed, max_lines. So very long outputs don't pollute the user environment. Update print.rocrate_validation generic to print using message, instead of cat.
…t.summary.* generics for those methods.
Collaborator
Author
|
@elichad just to let you know that this is a new release of the package, now at a more mature stage! Which has also been released on CRAN. |
Contributor
|
@villegar thanks for letting me know :) I can't contribute much in the way of helpful review here - so my main question is just whether all the new features have been documented. I guess that they have been, as I see updates to the docs and a new vignette - so I have no objection to merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
load_rocrate.validate_rocrate.__MACOSXon macOS).is_rocrate.get_entityso it takes a vector foridandtype, reuses the shorter vector (only if the length 1), or errors if vectors have different lengths.is_rocrate_bagso it returns a boolean value, indicating the validity of the given RO-Crate bag. Previously, it returned a path to the root of the RO-Crate.unbag_rocrateto return the path to RO-Crate root visibly.add_entities()is deprecated. Useadd_entity()instead.load_rocrate_bag()is deprecated. Useload_rocrate()instead. Note that validation must be done as a separate step usingvalidate_rocrate().read_rocrate()is deprecated. Useload_rocrate()instead.remove_entities()is deprecated. Useremove_entity()instead.entity(x=)renamed toentity(id=).Closes #5 and closes #7