Add outputDimensionality to gemini embeddings node#10
Open
danieldunderfelt wants to merge 2 commits into
Open
Conversation
|
UP!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the "outputDimensionality" field for the Google Gemini embeddings node. It was the reason I installed this node in the first place and I was disappointed to see it missing.
Note that I did not find a prettier config in the project, and running the format script as requested made quite a lot of changes. If this is a dealbreaker I can try to make the changes again and not format the code, but it would probably be better if you added a prettier config to the project to make the code format uniform.