RE1-T118 NWS API fix

Author: ucswift

Core/Resgrid.Model/PermanentWeatherAlertException.cs

@@ -0,0 +1,17 @@
+using System;
+
+namespace Resgrid.Model
+{
+	/// <summary>
+	/// Thrown when a weather alert API request fails due to a permanent, non-retriable condition
+	/// (e.g. invalid NWS zone code). Unlike <see cref="TransientWeatherAlertException"/>, callers
+	/// should mark the source as permanently failed and stop retrying until the user corrects the configuration.
+	/// </summary>
+	public class PermanentWeatherAlertException : Exception
+	{
+		public PermanentWeatherAlertException(string message) : base(message) { }
+
+		public PermanentWeatherAlertException(string message, Exception innerException)
+			: base(message, innerException) { }
+	}
+}

Core/Resgrid.Services/WeatherAlertService.cs

@@ -241,6 +241,17 @@ public async Task ProcessWeatherAlertSourceAsync(Guid sourceId, CancellationToke
 				source.ErrorMessage = null;
 				await _weatherAlertSourceRepository.UpdateAsync(source, ct, true);
 			}
+			catch (PermanentWeatherAlertException ex)
+			{
+				// Permanent failures (invalid zone codes, etc.) — record the error
+				// and mark the source as failed. Don't rethrow so the poller continues
+				// without noisy Fatal logs. The source will be retried only after the
+				// user edits and saves it.
+				source.LastPollUtc = DateTime.UtcNow;
+				source.IsFailure = true;
+				source.ErrorMessage = ex.Message;
+				await _weatherAlertSourceRepository.UpdateAsync(source, ct, true);
+			}
 			catch (TransientWeatherAlertException ex)
 			{
 				// Transient failures (rate-limit, server errors) — record the error
@@ -268,6 +279,12 @@ public async Task ProcessAllActiveSourcesAsync(CancellationToken ct = default)
 
 			foreach (var source in sources)
 			{
+				// Skip sources with permanent failures (e.g. invalid zone codes).
+				// They will be retried only after the user edits and saves the source.
+				if (source.IsFailure && !string.IsNullOrEmpty(source.ErrorMessage) &&
+					!source.ErrorMessage.StartsWith("Transient:"))
+					continue;
+
 				// Check if it's time to poll based on interval
 				if (source.LastPollUtc.HasValue)
 				{

Providers/Resgrid.Providers.Weather/NwsWeatherAlertProvider.cs

@@ -55,12 +55,12 @@ public async Task<List<WeatherAlert>> FetchAlertsAsync(WeatherAlertSource source
 					var stateCodes = zones.Where(z => z.Length == 2).ToArray();
 					var zoneCodes = zones.Where(z => z.Length > 2).ToArray();
 
-					// Validate zone codes before calling the NWS API to produce a clear error
-					// instead of a cryptic 400 Bad Request from the upstream API.
-					var validationError = GetZoneValidationError(source.AreaFilter);
-					if (validationError != null)
-						throw new HttpRequestException(
-							$"Invalid NWS zone code in area filter for department {source.DepartmentId}: {validationError}");
+				// Validate zone codes before calling the NWS API to produce a clear error
+				// instead of a cryptic 400 Bad Request from the upstream API.
+				var validationError = GetZoneValidationError(source.AreaFilter);
+				if (validationError != null)
+					throw new PermanentWeatherAlertException(
+						$"Invalid NWS zone code in area filter for department {source.DepartmentId}: {validationError}");
 
 					var queryParams = new List<string>();
 					if (stateCodes.Length > 0)

Web/Resgrid.Web.Services/Controllers/v4/WeatherAlertsController.cs

@@ -206,6 +206,10 @@ public async Task<ActionResult<GetWeatherAlertSourcesResult>> SaveSource([FromBo
 				}
 			}
 
+			// Clear any previous permanent failure so the source will be retried on next poll.
+			source.IsFailure = false;
+			source.ErrorMessage = null;
+
 			await _weatherAlertService.SaveSourceAsync(source);
 
 			var department = await _departmentsService.GetDepartmentByIdAsync(DepartmentId, false);