RE1-T118 PR#379 fixes

Author: ucswift

Core/Resgrid.Model/WeatherAlertSource.cs

@@ -44,6 +44,8 @@ public class WeatherAlertSource : IEntity
 
 		public bool IsFailure { get; set; }
 
+		public bool IsPermanentFailure { get; set; }
+
 		[MaxLength(2000)]
 		public string ErrorMessage { get; set; }
 

Core/Resgrid.Services/WeatherAlertService.cs

@@ -238,6 +238,7 @@ public async Task ProcessWeatherAlertSourceAsync(Guid sourceId, CancellationToke
 				source.LastPollUtc = DateTime.UtcNow;
 				source.LastSuccessUtc = DateTime.UtcNow;
 				source.IsFailure = false;
+				source.IsPermanentFailure = false;
 				source.ErrorMessage = null;
 				await _weatherAlertSourceRepository.UpdateAsync(source, ct, true);
 			}
@@ -249,6 +250,7 @@ public async Task ProcessWeatherAlertSourceAsync(Guid sourceId, CancellationToke
 				// user edits and saves it.
 				source.LastPollUtc = DateTime.UtcNow;
 				source.IsFailure = true;
+				source.IsPermanentFailure = true;
 				source.ErrorMessage = ex.Message;
 				await _weatherAlertSourceRepository.UpdateAsync(source, ct, true);
 			}
@@ -281,8 +283,7 @@ public async Task ProcessAllActiveSourcesAsync(CancellationToken ct = default)
 			{
 				// Skip sources with permanent failures (e.g. invalid zone codes).
 				// They will be retried only after the user edits and saves the source.
-				if (source.IsFailure && !string.IsNullOrEmpty(source.ErrorMessage) &&
-					!source.ErrorMessage.StartsWith("Transient:"))
+				if (source.IsFailure && source.IsPermanentFailure)
 					continue;
 
 				// Check if it's time to poll based on interval

Providers/Resgrid.Providers.Migrations/Migrations/M0068_AddIsPermanentFailureToWeatherAlertSources.cs

@@ -0,0 +1,19 @@
+using FluentMigrator;
+
+namespace Resgrid.Providers.Migrations.Migrations
+{
+	[Migration(68)]
+	public class M0068_AddIsPermanentFailureToWeatherAlertSources : Migration
+	{
+		public override void Up()
+		{
+			Alter.Table("WeatherAlertSources")
+				.AddColumn("IsPermanentFailure").AsBoolean().NotNullable().WithDefaultValue(false);
+		}
+
+		public override void Down()
+		{
+			Delete.Column("IsPermanentFailure").FromTable("WeatherAlertSources");
+		}
+	}
+}

Providers/Resgrid.Providers.MigrationsPg/Migrations/M0068_AddIsPermanentFailureToWeatherAlertSourcesPg.cs

@@ -0,0 +1,19 @@
+using FluentMigrator;
+
+namespace Resgrid.Providers.MigrationsPg.Migrations
+{
+	[Migration(68)]
+	public class M0068_AddIsPermanentFailureToWeatherAlertSourcesPg : Migration
+	{
+		public override void Up()
+		{
+			Alter.Table("weatheralertsources")
+				.AddColumn("ispermanentfailure").AsBoolean().NotNullable().WithDefaultValue(false);
+		}
+
+		public override void Down()
+		{
+			Delete.Column("ispermanentfailure").FromTable("weatheralertsources");
+		}
+	}
+}

Web/Resgrid.Web.Services/Controllers/v4/WeatherAlertsController.cs

@@ -208,6 +208,7 @@ public async Task<ActionResult<GetWeatherAlertSourcesResult>> SaveSource([FromBo
 
 			// Clear any previous permanent failure so the source will be retried on next poll.
 			source.IsFailure = false;
+			source.IsPermanentFailure = false;
 			source.ErrorMessage = null;
 
 			await _weatherAlertService.SaveSourceAsync(source);
@@ -486,6 +487,7 @@ private static WeatherAlertSourceResultData MapSourceToResultData(WeatherAlertSo
 				LastPollUtc = source.LastPollUtc?.TimeConverterToString(department),
 				LastSuccessUtc = source.LastSuccessUtc?.TimeConverterToString(department),
 				IsFailure = source.IsFailure,
+				IsPermanentFailure = source.IsPermanentFailure,
 				ErrorMessage = source.ErrorMessage
 			};
 		}

Web/Resgrid.Web.Services/Models/v4/WeatherAlerts/WeatherAlertSourceResultData.cs

@@ -14,6 +14,7 @@ public class WeatherAlertSourceResultData
 		public string LastPollUtc { get; set; }
 		public string LastSuccessUtc { get; set; }
 		public bool IsFailure { get; set; }
+		public bool IsPermanentFailure { get; set; }
 		public string ErrorMessage { get; set; }
 	}
 }

Web/Resgrid.Web/Areas/User/Views/WeatherAlerts/Settings.cshtml

@@ -165,6 +165,7 @@
 												areaFilter = source.AreaFilter ?? "",
 												pollInterval = source.PollIntervalMinutes,
 												active = source.Active,
+												isPermanentFailure = source.IsPermanentFailure,
 												errorMessage = source.ErrorMessage ?? ""
 											});
 										}