RE1-T117 Fixing migration issue

[ucswift]

Summary by CodeRabbit

• Chores
  • Optimized database performance through improved indexing strategies on both SQL Server and PostgreSQL environments to enhance query efficiency for reporting operations.

[request-info]

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cf403121-fecc-4a9b-b90d-cc0bfbcc91db

📥 Commits

Reviewing files that changed from the base of the PR and between d7a7e6b and 9f7424b.

📒 Files selected for processing (2)

• Providers/Resgrid.Providers.Migrations/Migrations/M0073_AddingReportingIndexes.cs
• Providers/Resgrid.Providers.MigrationsPg/Migrations/M0073_AddingReportingIndexesPg.cs

---

📝 Walkthrough

Walkthrough

The PR refactors the IX_Calls_DepartmentId_Type index in both SQL Server and PostgreSQL migration files. The index key is simplified to include only DepartmentId, with Type moved to an included (non-key) column. This change is applied consistently across both database dialects with supporting comments explaining the rationale.

Changes

Index Optimization for Calls Reporting

Layer / File(s)	Summary
Calls table index refactoring (SQL Server and PostgreSQL) Providers/Resgrid.Providers.Migrations/Migrations/M0073_AddingReportingIndexes.cs, Providers/Resgrid.Providers.MigrationsPg/Migrations/M0073_AddingReportingIndexesPg.cs	The IX_Calls_DepartmentId_Type index is redefined with DepartmentId as the key and Type as an included column in both SQL Server and PostgreSQL migrations. The SQL Server migration adds the FluentMigrator.SqlServer namespace import. Both migrations include updated comments explaining the index structure change and database-specific constraints.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'RE1-T117 Fixing migration issue' is vague and generic. It mentions a ticket reference and broadly refers to 'migration issue' without clarifying what specific aspect of the migrations is being fixed (e.g., index optimization, SQL Server nvarchar(max) constraint handling).	Use a more descriptive title that captures the specific change, such as 'Refactor index strategy to use INCLUDE columns for Calls table' or 'Optimize IX_Calls_DepartmentId_Type index across SQL Server and PostgreSQL migrations'.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ucswift]

Approve

[github-actions]

This PR is approved.