Add PHPStan level 8, update CI workflow, add repo configs

Add phpstan.neon.dist at level 8 (matching Validation) with only 3
remaining ignores for irreducible __set magic method tests. Fix source:
type Instantiator constructor with @param class-string, use
assert(is_callable()) for call_user_func, assert(Closure|string) for
ReflectionFunction, use ReflectionNamedType, null-safe key(), cast
preg_replace results. Fix tests: replace magic __get reads with
getItem()/get(), magic __call with __invoke + getItem, bare expressions
with get(), parse_ini_string with parseIni() helper, getcwd() with
assertion, class_alias constant with original class. Replace single-job
CI with 3 parallel jobs: tests, code coverage with Codecov, static
analysis. Add codecov.yml, .gitattributes, dependabot.yml.

Author: alganet

.gitattributes

@@ -0,0 +1,6 @@
+/* export-ignore
+
+# Project files
+/README.md -export-ignore
+/composer.json -export-ignore
+/src -export-ignore

.github/dependabot.yml

@@ -0,0 +1,14 @@
+version: 2
+updates:
+
+  # Maintain dependencies for GitHub Actions
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+
+  # Maintain dependencies for Composer
+  - package-ecosystem: "composer"
+    directory: "/"
+    schedule:
+      interval: "weekly"

.github/workflows/ci.yml

@@ -6,30 +6,42 @@ on:
   pull_request:
 
 jobs:
-  test:
+  tests:
+    name: Tests
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        php: [ '8.5' ]
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
+      - uses: actions/checkout@v6
+      - uses: shivammathur/setup-php@v2
         with:
-          php-version: ${{ matrix.php }}
+          php-version: '8.5'
+      - uses: ramsey/composer-install@v3
+      - run: composer phpunit
 
-      - name: Get composer cache
-        uses: actions/cache@v4
+  code-coverage:
+    name: Code Coverage
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: shivammathur/setup-php@v2
         with:
-          path: ~/.cache/composer
-          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-composer-
-
-      - name: Install dependencies
-        run: composer install --no-progress --no-suggest --prefer-dist --no-interaction
+          php-version: '8.5'
+          coverage: pcov
+      - uses: ramsey/composer-install@v3
+      - name: Generate coverage report
+        run: vendor/bin/phpunit --coverage-clover=coverage.xml
+      - name: Upload to Codecov
+        uses: codecov/codecov-action@v5
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
 
-      - name: Run PHPUnit
-        run: vendor/bin/phpunit --configuration phpunit.xml.dist
+  static-analysis:
+    name: Static Analysis
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.5'
+      - uses: ramsey/composer-install@v3
+      - run: composer phpcs
+      - run: composer phpstan

codecov.yml

@@ -0,0 +1,6 @@
+coverage:
+  status:
+    project:
+      default:
+        target: 95%    # the required coverage value
+        threshold: 1%  # the leniency in hitting the target

phpcs.xml.dist

@@ -22,6 +22,11 @@
         <exclude-pattern>src/Instantiator.php</exclude-pattern>
     </rule>
 
+    <!-- @var class-string narrowing for PHPStan on dynamic class names from INI -->
+    <rule ref="SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration.MissingVariable">
+        <exclude-pattern>src/</exclude-pattern>
+    </rule>
+
     <!-- Test files contain inline fixture classes required by the DI container tests -->
     <rule ref="PSR1.Classes.ClassDeclaration.MultipleClasses">
         <exclude-pattern>tests/</exclude-pattern>

phpstan.neon.dist

@@ -0,0 +1,15 @@
+parameters:
+  level: 8
+  paths:
+    - src/
+    - tests/
+  ignoreErrors:
+    # __set writes that test Container's Instantiator replacement logic
+    -
+      message: '/Access to an undefined property Respect\\Config\\Container::\$/'
+      path: tests/ContainerTest.php
+      count: 1
+    -
+      message: '/Access to an undefined property Respect\\Config\\Container::\$/'
+      path: tests/LazyLoadTest.php
+      count: 2

src/Container.php

@@ -10,9 +10,11 @@
 use Psr\Container\ContainerInterface;
 use ReflectionClass;
 use ReflectionFunction;
+use ReflectionNamedType;
 
 use function array_filter;
 use function array_map;
+use function assert;
 use function constant;
 use function count;
 use function current;
@@ -32,6 +34,7 @@
 use function str_contains;
 use function trim;
 
+/** @extends ArrayObject<string, mixed> */
 class Container extends ArrayObject implements ContainerInterface
 {
     public function __construct(protected mixed $configurator = null)
@@ -191,7 +194,7 @@ protected function parseStandardItem(string $key, mixed &$value): void
 
     protected function removeDuplicatedSpaces(string $string): string
     {
-        return preg_replace('/\s+/', ' ', $string);
+        return (string) preg_replace('/\s+/', ' ', $string);
     }
 
     protected function parseInstantiator(string $key, mixed $value): void
@@ -202,6 +205,7 @@ protected function parseInstantiator(string $key, mixed $value): void
             $keyName = $keyClass;
         }
 
+        /** @var class-string $keyClass */
         $instantiator = new Instantiator($keyClass);
 
         if (is_array($value)) {
@@ -297,7 +301,7 @@ protected function parseBrackets(string $value): mixed
 
     protected function parseVariables(string $value): string
     {
-        return preg_replace_callback(
+        return (string) preg_replace_callback(
             '/\[(\w+)\]/',
             fn(array $match): string => $this[$match[1]] ?: '',
             $value,
@@ -337,17 +341,16 @@ public function __invoke(mixed $spec): mixed
                 $mirror = $class->getMethod($method);
             } else {
                 $object = false;
+                assert($spec instanceof Closure || is_string($spec));
                 $mirror = new ReflectionFunction($spec);
             }
 
             $container = $this;
             $arguments = array_map(
                 static function ($param) use ($container) {
                     $paramClass = $param->getType();
-                    if ($paramClass) {
-                        $paramClassName = $paramClass->getName();
-
-                        return $container->getItem($paramClassName);
+                    if ($paramClass instanceof ReflectionNamedType) {
+                        return $container->getItem($paramClass->getName());
                     }
 
                     return null;

src/Instantiator.php

@@ -5,13 +5,15 @@
 use ReflectionClass;
 
 use function array_key_exists;
+use function assert;
 use function call_user_func;
 use function call_user_func_array;
 use function count;
 use function end;
 use function explode;
 use function func_get_args;
 use function is_array;
+use function is_callable;
 use function is_object;
 use function key;
 use function str_contains;
@@ -25,6 +27,7 @@ class Instantiator
 
     protected mixed $instance = null;
 
+    /** @var ReflectionClass<object> */
     protected ReflectionClass $reflection;
 
     /** @var array<string, mixed> */
@@ -44,11 +47,14 @@ class Instantiator
 
     protected string|false $mode = self::MODE_DEPENDENCY;
 
+    /** @param class-string $className */
     public function __construct(protected string $className)
     {
         if (str_contains(strtolower($className), ' ')) {
             [$mode, $className] = explode(' ', $className, 2);
             $this->mode = $mode;
+            /** @var class-string $className */
+            $this->className = $className;
         }
 
         $this->reflection = new ReflectionClass($className);
@@ -158,7 +164,12 @@ public function getParams(): array
     protected function cleanupParams(array $params): array
     {
         while (end($params) === null) {
-            unset($params[key($params)]);
+            $key = key($params);
+            if ($key === null) {
+                break;
+            }
+
+            unset($params[$key]);
         }
 
         foreach ($params as &$p) {
@@ -173,7 +184,11 @@ protected function lazyLoad(mixed $value): mixed
         return $value instanceof self ? $value->getInstance() : $value;
     }
 
-    /** @return array<string, mixed> */
+    /**
+     * @param ReflectionClass<object> $class
+     *
+     * @return array<string, mixed>
+     */
     protected function findConstructorParams(ReflectionClass $class): array
     {
         $params = [];
@@ -233,16 +248,19 @@ protected function performMethodCalls(
         $resultCallback ??= static function (): void {
         };
 
+        $callable = [$class, $methodName];
+        assert(is_callable($callable));
+
         foreach ($calls as $arguments) {
             if (is_array($arguments)) {
                 $resultCallback(call_user_func_array(
-                    [$class, $methodName],
+                    $callable,
                     $this->cleanupParams($arguments),
                 ));
             } elseif ($arguments !== null) {
-                $resultCallback(call_user_func([$class, $methodName], $this->lazyLoad($arguments)));
+                $resultCallback(call_user_func($callable, $this->lazyLoad($arguments)));
             } else {
-                $resultCallback(call_user_func([$class, $methodName]));
+                $resultCallback(call_user_func($callable));
             }
         }
     }