Implementing Container Interoperability

Author: abdala

composer.json

@@ -17,7 +17,8 @@
         }
     },
     "require": {
-        "php": ">=5.3.0"
+        "php": ">=5.3.0",
+        "container-interop/container-interop": "^1.1"
     },
     "require-dev": {
         "phpunit/phpunit": "~4.4",

library/Respect/Config/Container.php

@@ -6,8 +6,9 @@
 use ArrayObject;
 use ReflectionClass;
 use ReflectionFunction;
+use Interop\Container\ContainerInterface;
 
-class Container extends ArrayObject
+class Container extends ArrayObject implements ContainerInterface
 {
     protected $configurator;
 
@@ -17,6 +18,11 @@ public function __construct($configurator = null)
     }
 
     public function __isset($name)
+    {
+        return $this->has($name);
+    }
+    
+    public function has($name) 
     {
         if ($this->configurator) {
             $this->configure();
@@ -101,15 +107,15 @@ protected function configure()
 
         throw new Argument("Invalid input. Must be a valid file or array");
     }
-
+    
     public function getItem($name, $raw = false)
     {
         if ($this->configurator) {
             $this->configure();
         }
 
         if (!isset($this[$name])) {
-            throw new Argument("Item $name not found");
+            throw new NotFoundException("Item $name not found");
         }
 
         if ($raw || !is_callable($this[$name])) {
@@ -118,6 +124,11 @@ public function getItem($name, $raw = false)
 
         return $this->lazyLoad($name);
     }
+    
+    public function get($name)
+    {
+        return $this->getItem($name);
+    }
 
     public function loadString($configurator)
     {

library/Respect/Config/NotFoundException.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace Respect\Config;
+
+use Interop\Container\Exception\NotFoundException as BaseNotFoundException;
+
+class NotFoundException extends \Exception implements BaseNotFoundException
+{
+}

tests/library/Respect/Config/ContainerTest.php

@@ -48,6 +48,33 @@ public function testLoadFile()
         $this->assertEquals('bar', $c->getItem('foo'));
         $this->assertEquals('bat', $c->getItem('baz'));
     }
+    
+    public function testContainerInterop()
+    {
+        $ini = <<<INI
+foo = bar
+baz = bat
+INI;
+        $c = new Container;
+        $c->loadArray(parse_ini_string($ini, true));
+        $this->assertTrue($c->has('foo'));
+        $this->assertEquals('bar', $c->get('foo'));
+        $this->assertEquals('bat', $c->get('baz'));
+    }
+    
+    /**
+     * @expectedException Interop\Container\Exception\NotFoundException
+     * @expectedExceptionMessage Item baz not found
+     */
+    public function testLoadInvalidName()
+    {
+        $ini = <<<INI
+foo = bar
+INI;
+        $c = new Container;
+        $c->loadArray(parse_ini_string($ini, true));
+        $c->get('baz');
+    }
 
     /**
      * @expectedException InvalidArgumentException