Skip to content

Declare Builder mixin methods as static for static analysis support #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henriquemoody merged 5 commits into from
Feb 7, 2026
Merged

Declare Builder mixin methods as static for static analysis support #16

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d56c48
Initial plan
Copilot Feb 6, 2026
4d8e82f
Initial exploration and plan creation
Copilot Feb 6, 2026
50ba720
Make Builder interface methods static for static analysis
Copilot Feb 6, 2026
2bc1a13
Add .phpunit.result.cache to .gitignore
Copilot Feb 6, 2026
a80f98d
Revert platform-check configuration change
Copilot Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
.phpcs.cache
.phpunit.cache/
.phpunit.result.cache
/vendor/
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"phpstan/extension-installer": true,
"dealerdirect/phpcodesniffer-composer-installer": true
},
"sort-packages": true
"sort-packages": true,
"platform-check": false
Copy link
Copy Markdown
Member

@henriquemoody henriquemoody Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert that change

Copy link
Copy Markdown
Contributor Author

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in a80f98d

}
}
24 changes: 12 additions & 12 deletions src/Mixin/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,32 +16,32 @@
/** @mixin FormatterBuilder */
interface Builder
{
public function area(string $unit): FormatterBuilder;
public static function area(string $unit): FormatterBuilder;

public function imperialArea(string $unit): FormatterBuilder;
public static function imperialArea(string $unit): FormatterBuilder;

public function imperialLength(string $unit): FormatterBuilder;
public static function imperialLength(string $unit): FormatterBuilder;

public function imperialMass(string $unit): FormatterBuilder;
public static function imperialMass(string $unit): FormatterBuilder;

public function date(string $format = 'Y-m-d H:i:s'): FormatterBuilder;
public static function date(string $format = 'Y-m-d H:i:s'): FormatterBuilder;

public function mask(string $range, string $replacement = '*'): FormatterBuilder;
public static function mask(string $range, string $replacement = '*'): FormatterBuilder;

public function metric(string $unit): FormatterBuilder;
public static function metric(string $unit): FormatterBuilder;

public function number(
public static function number(
int $decimals = 0,
string $decimalSeparator = '.',
string $thousandsSeparator = ',',
): FormatterBuilder;

public function metricMass(string $unit): FormatterBuilder;
public static function metricMass(string $unit): FormatterBuilder;

public function pattern(string $pattern): FormatterBuilder;
public static function pattern(string $pattern): FormatterBuilder;

/** @param array<string, mixed> $parameters */
public function placeholder(array $parameters): FormatterBuilder;
public static function placeholder(array $parameters): FormatterBuilder;

public function time(string $unit): FormatterBuilder;
public static function time(string $unit): FormatterBuilder;
}