Change how we trace the path of results#1532
Merged
Merged
Conversation
b57c21a to
fc9bfc0
Compare
fc9bfc0 to
22cc869
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
============================================
- Coverage 97.53% 97.51% -0.03%
- Complexity 966 982 +16
============================================
Files 199 203 +4
Lines 2153 2216 +63
============================================
+ Hits 2100 2161 +61
- Misses 53 55 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
22cc869 to
abe204a
Compare
alganet
reviewed
Nov 24, 2025
cab88fe to
c20a53c
Compare
henriquemoody
commented
Dec 20, 2025
henriquemoody
commented
Dec 20, 2025
henriquemoody
commented
Dec 20, 2025
henriquemoody
commented
Dec 20, 2025
8782d9a to
f828187
Compare
c89b23e to
6a79a77
Compare
6a79a77 to
f274d9f
Compare
Currently, we’re using scalar values to trace paths. The problem with that approach is that we can’t create a reliable hierarchy with them, as we can’t know for sure when a path is the same for different rules. By using an object, we can easily compare and create a parent-child relationship with it. While making these changes, I deemed it necessary to also create objects to handle Name and Id, which makes the code simpler and more robust. By having Name and Path, we can create specific stringifiers that allow us to customise how we render those values. I didn’t manage to make those changes atomically, which is why this commit makes so many changes. I found myself moving back and forth, and making all those changes at once was the best solution I found.
f274d9f to
137c74c
Compare
henriquemoody
commented
Dec 20, 2025
alganet
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we’re using scalar values to trace paths. The problem with that approach is that we can’t create a reliable hierarchy with them, as we can’t know for sure when a path is the same for different rules. By using an object, we can easily compare and create a parent-child relationship with it.
While making these changes, I deemed it necessary to also create objects to handle Name and Id, which makes the code simpler and more robust. By having Name and Path, we can create specific stringifiers that allow us to customise how we render those values.
I didn’t manage to make those changes atomically, which is why this commit makes so many changes. I found myself moving back and forth, and making all those changes at once was the best solution I found.