Do not use array_unique() in the Unique rule#1540
Merged
Merged
Conversation
henriquemoody
force-pushed
the
pr/1534
branch
4 times, most recently
from
e485eff to
59be2e6
Compare
The default value of the second argument of `array_unique()` is `SORT_STRING`. This means that it converts all values to strings. That was the reason we were using `SORT_REGULAR`, but when using `SORT_REGULAR`, the strings `14.1` and `14.10` are considered the same, even though they're different. This commit will change the `Unique` rule to implement its own way of detecting uniqueness. This was necessary because `array_unique() 's limitation is handling different types in the same array. Co-authored-by: Henrique Moody <henriquemoody@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value of the second argument of
array_unique()isSORT_STRING. This means that it converts all values to strings. That was the reason we were usingSORT_REGULAR, but when usingSORT_REGULAR, the strings14.1and14.10are considered the same, even though they're different.This commit will change the
Uniquerule to implement its own way of detecting uniqueness. This was necessary because `array_unique() 's limitation is handling different types in the same array.Closes #1534 & #1533