Skip to content

Remove now unecessary fallback to json_decode #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alganet merged 1 commit into from
Jan 29, 2026
Merged

Remove now unecessary fallback to json_decode #1637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions src/Validators/Json.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,9 @@
use Respect\Validation\Message\Template;
use Respect\Validation\Validators\Core\Simple;

use function function_exists;
use function is_string;
use function json_decode;
use function json_last_error;
use function json_validate;

use const JSON_ERROR_NONE;

#[Attribute(Attribute::TARGET_PROPERTY | Attribute::IS_REPEATABLE)]
#[Template(
'{{subject}} must be a valid JSON string',
Expand All @@ -44,12 +39,6 @@ public function isValid(mixed $input): bool
return false;
}

if (function_exists('json_validate')) {
return json_validate($input);
}

json_decode($input);

return json_last_error() === JSON_ERROR_NONE;
return json_validate($input);
}
}
Loading