Change CI Perf to run on schedule, no runs on PRs#1646
Merged
alganet merged 1 commit intoRespect:mainfrom Jan 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1646 +/- ##
============================================
+ Coverage 99.00% 99.14% +0.13%
Complexity 962 962
============================================
Files 197 197
Lines 2214 2215 +1
============================================
+ Hits 2192 2196 +4
+ Misses 22 19 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the CI performance benchmark workflow to stop running on pull requests and instead run on a daily schedule plus pushes to main, aiming to gather benchmark history while avoiding PR friction.
Changes:
- Switch
ci-perftriggers toschedule(daily) andpushtomain, removingpull_requesttriggers. - Simplify phpbench execution to always compare against
latestusing--tolerate-failure. - Make the benchmark job non-blocking via
continue-on-error: true.
Comments suppressed due to low confidence (1)
.github/workflows/ci-perf.yml:21
workflow_dispatchexposes arebaselineoption, but the workflow currently only commits benchmark/baseline updates onpushevents. That means a manualrebaselinerun won’t actually update thebenchmarksbranch. Consider allowing the “Commit Results” logic to run forworkflow_dispatch(at least whenbaseline == rebaseline) so the input has the intended effect.
workflow_dispatch:
inputs:
baseline:
description: 'Baseline mode. latest: compare against latest benchmarks; rebaseline: store new baseline.'
type: choice
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alganet
force-pushed
the
ci-perf-sched
branch
from
4af17bc to
b3ec46e
Compare
alganet
force-pushed
the
ci-perf-sched
branch
2 times, most recently
from
4a60146 to
ff9d4e5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
See Respect#1635 The goal is to collect data for a while. Until we have enough benchmarks, the PR check is not very useful, so it was disabled. We added `--tolerate-failure` to all runs, so this check will never fail because of a missed performance assertion, but it will report it and archive it.
alganet
force-pushed
the
ci-perf-sched
branch
from
ff9d4e5 to
cba9efd
Compare
henriquemoody
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1635
The goal is to collect data for a while. Until we have enough benchmarks, the PR check is not very useful, so it was disabled.
We added
--tolerate-failureto all runs, so this check will never fail because of a missed performance assertion, but it will report it and archive it.