Skip to content

Commit cd68821

Browse files
committed
prevent long sleep in test
1 parent c7776d1 commit cd68821

2 files changed

Lines changed: 26 additions & 8 deletions

File tree

restcomm/restcomm.dao/src/main/java/org/restcomm/connect/dao/entities/SmsMessage.java

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,14 +155,21 @@ public static final class Builder {
155155
private Currency priceUnit;
156156
private String apiVersion;
157157
private URI uri;
158+
private DateTime dateCreated;
159+
private DateTime dateUpdated;
158160

159161
private Builder() {
160162
super();
161163
}
162164

163165
public SmsMessage build() {
164-
final DateTime now = DateTime.now();
165-
return new SmsMessage(sid, now, now, dateSent, accountSid, sender, recipient, body, status, direction, price,
166+
if (dateCreated == null) {
167+
dateCreated = DateTime.now();
168+
}
169+
if (dateUpdated == null) {
170+
dateUpdated = dateCreated;
171+
}
172+
return new SmsMessage(sid, dateCreated, dateUpdated, dateSent, accountSid, sender, recipient, body, status, direction, price,
166173
priceUnit, apiVersion, uri);
167174
}
168175

@@ -213,6 +220,14 @@ public void setApiVersion(final String apiVersion) {
213220
public void setUri(final URI uri) {
214221
this.uri = uri;
215222
}
223+
224+
public void setDateCreated(DateTime dateCreated) {
225+
this.dateCreated = dateCreated;
226+
}
227+
228+
public void setDateUpdated(DateTime dateUpdated) {
229+
this.dateUpdated = dateUpdated;
230+
}
216231
}
217232

218233
public enum Direction {

restcomm/restcomm.dao/src/test/java/org/restcomm/connect/dao/mybatis/SmsMessagesDaoTest.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public void createReadUpdateDelete() {
114114
assertTrue(messages.getSmsMessage(sid) == null);
115115
}
116116

117-
private SmsMessage createSms(Sid account, SmsMessage.Direction direction, int i) {
117+
private SmsMessage createSms(Sid account, SmsMessage.Direction direction, int i, DateTime date) {
118118
final Sid sid = Sid.generate(Sid.Type.SMS_MESSAGE);
119119
final URI url = URI.create("2012-04-24/Accounts/Acoount/SMS/Messages/unique-id.json");
120120
final SmsMessage.Builder builder = SmsMessage.builder();
@@ -129,6 +129,7 @@ private SmsMessage createSms(Sid account, SmsMessage.Direction direction, int i)
129129
builder.setPrice(new BigDecimal("0.00"));
130130
builder.setPriceUnit(Currency.getInstance("USD"));
131131
builder.setUri(url);
132+
builder.setDateCreated(date);
132133
SmsMessage message = builder.build();
133134
return message;
134135
}
@@ -137,30 +138,32 @@ private SmsMessage createSms(Sid account, SmsMessage.Direction direction, int i)
137138
public void testGetSmsMessagesLastMinute() throws InterruptedException, ParseException {
138139
final SmsMessagesDao messages = manager.getSmsMessagesDao();
139140
final Sid account = Sid.generate(Sid.Type.ACCOUNT);
141+
DateTime oneMinuteAgo = DateTime.now().minusSeconds(58);
140142
for (int i = 0; i < 2; i++) {
141-
SmsMessage message = createSms(account, SmsMessage.Direction.OUTBOUND_API, i);
143+
SmsMessage message = createSms(account, SmsMessage.Direction.OUTBOUND_API, i, oneMinuteAgo);
142144
// Create a new sms message in the data store.
143145
messages.addSmsMessage(message);
144146
logger.info("Created message: "+message);
145147
}
146148
for (int i = 0; i < 2; i++) {
147-
SmsMessage message = createSms(account, SmsMessage.Direction.OUTBOUND_CALL, i);
149+
SmsMessage message = createSms(account, SmsMessage.Direction.OUTBOUND_CALL, i, oneMinuteAgo);
148150
// Create a new sms message in the data store.
149151
messages.addSmsMessage(message);
150152
logger.info("Created message: "+message);
151153
}
152154
for (int i = 0; i < 2; i++) {
153-
SmsMessage message = createSms(account, SmsMessage.Direction.OUTBOUND_REPLY, i);
155+
SmsMessage message = createSms(account, SmsMessage.Direction.OUTBOUND_REPLY, i, oneMinuteAgo);
154156
// Create a new sms message in the data store.
155157
messages.addSmsMessage(message);
156158
logger.info("Created message: "+message);
157159
}
158160
int lastMessages = messages.getSmsMessagesPerAccountLastPerMinute(account.toString());
159161
logger.info("SMS Messages last minutes: "+lastMessages);
160162
assertEquals(6, lastMessages);
161-
Thread.sleep(70000);
163+
Thread.sleep(5000);
164+
DateTime oneMinuteLater = DateTime.now();
162165
for (int i = 0; i < 3; i++) {
163-
SmsMessage message = createSms(account, SmsMessage.Direction.OUTBOUND_CALL, i);
166+
SmsMessage message = createSms(account, SmsMessage.Direction.OUTBOUND_CALL, i, oneMinuteLater);
164167
// Create a new sms message in the data store.
165168
messages.addSmsMessage(message);
166169
logger.info("Created message: "+message);

0 commit comments

Comments
 (0)