Skip to content

Commit ff97d9f

Browse files
committed
use EmailValidator in EmailMessageEndpoint
1 parent da50dcf commit ff97d9f

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

restcomm/restcomm.http/src/main/java/org/restcomm/connect/http/EmailMessagesEndpoint.java

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import org.restcomm.connect.email.api.Mail;
2727
import org.restcomm.connect.http.converter.EmailMessageConverter;
2828
import org.restcomm.connect.http.converter.RestCommResponseConverter;
29+
import org.restcomm.connect.identity.EmailValidator;
2930

3031
import javax.annotation.PostConstruct;
3132
import javax.servlet.ServletContext;
@@ -182,32 +183,24 @@ private void validate(final MultivaluedMap<String, String> data) throws NullPoin
182183

183184

184185
public String validateEmail(String email) throws InvalidEmailException {
185-
String ePattern = "^[a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@((\\[[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\])|(([a-zA-Z\\-0-9]+\\.)+[a-zA-Z]{2,}))$";
186-
java.util.regex.Pattern p = java.util.regex.Pattern.compile(ePattern);
187-
java.util.regex.Matcher m = p.matcher(email);
188-
if (!m.matches()) {
186+
if (!EmailValidator.isValidEmailFormat(email)) {
189187
String err = "Not a Valid Email Address";
190188
throw new InvalidEmailException(err);
191189
}
192190
return email;
193191
}
194192

195193
public String validateEmails(String emails) throws InvalidEmailException {
196-
String ePattern = "^[a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@((\\[[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\])|(([a-zA-Z\\-0-9]+\\.)+[a-zA-Z]{2,}))$";
197-
java.util.regex.Pattern p = java.util.regex.Pattern.compile(ePattern);
198-
199194
if (emails.indexOf(',') > 0) {
200195
String[] emailsArray = emails.split(",");
201196
for (int i = 0; i < emailsArray.length; i++) {
202-
java.util.regex.Matcher m = p.matcher(emailsArray[i]);
203-
if (!m.matches()) {
197+
if (!EmailValidator.isValidEmailFormat(emailsArray[i])) {
204198
String err = "Not a Valid Email Address:" + emailsArray[i];
205199
throw new InvalidEmailException(err);
206200
}
207201
}
208-
}else{
209-
java.util.regex.Matcher m = p.matcher(emails);
210-
if (!m.matches()) {
202+
} else {
203+
if (!EmailValidator.isValidEmailFormat(emails)) {
211204
String err = "Not a Valid Email Address";
212205
throw new InvalidEmailException(err);
213206
}

0 commit comments

Comments
 (0)