New API: Deleting User's Profile#45
Open
farbodahm wants to merge 4 commits into
Open
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
pesarkhobeee
requested changes
Feb 11, 2021
pesarkhobeee
left a comment
pesarkhobeee
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 4 of 8 files at r1.
Reviewable status: 4 of 8 files reviewed, 2 unresolved discussions (waiting on @farbodahm)
tests/test_forget_password.py, line 245 at r1 (raw file):
def test_delete_user_profile_accepted(client):
Why this particular test is in this file?
shouldn't be in test_user.py ?
tests/test_user.py, line 962 at r1 (raw file):
def test_login_deleted_profile_failed(client):
Also, this test's place smells for me!
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, user's can delete their profile by sending a
DELETErequest to/user/profileroute.(This will delete their links too)
This change is