refactor: unexport internal helpers, drop dead MCP_JSON_FORMAT_VERSION

Knip flagged 12 unused exports and 8 unused exported types — all were
internal helpers that leaked public visibility by accident. No external
callers existed; the module public API was always the narrow set of
functions imported by tool files.

Changes per file:
- repo-paths.ts: realPathOrSelf (used only by isStrictlyUnderGitTop)
- json.ts: drop MCP_JSON_FORMAT_VERSION (unreferenced dead code),
  unexport readPackageVersion (called only by readMcpServerVersion)
- presets.ts: unexport PresetEntry/File/Load* types, splitPresetFileRaw,
  getPresetEntry, mergeNestedRoots, mergePairs
- roots.ts: unexport uriToPath, listFileRoots, pathMatchesWorkspaceRootHint,
  resolveWorkspaceRoots, resolveRootsForPreset, RootPick/ResolveRootsResult/
  GitAndRootsResult types

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: AlbinoGeek

src/repo-paths.ts

@@ -1,7 +1,7 @@
 import { realpathSync } from "node:fs";
 import { isAbsolute, relative, resolve } from "node:path";
 
-export function realPathOrSelf(p: string): string {
+function realPathOrSelf(p: string): string {
   try {
     return realpathSync(p);
   } catch {

src/server/json.ts

@@ -2,9 +2,7 @@ import { readFileSync } from "node:fs";
 import { dirname, join } from "node:path";
 import { fileURLToPath } from "node:url";
 
-export const MCP_JSON_FORMAT_VERSION = "2" as const;
-
-export function readPackageVersion(): string {
+function readPackageVersion(): string {
   const here = dirname(fileURLToPath(import.meta.url));
   const pkgPath = join(here, "..", "..", "package.json");
   try {

src/server/presets.ts

@@ -24,26 +24,26 @@ const PresetEntrySchema = z.object({
 
 const PresetFileSchema = z.record(z.string(), PresetEntrySchema);
 
-export type PresetEntry = z.infer<typeof PresetEntrySchema>;
-export type PresetFile = z.infer<typeof PresetFileSchema>;
+type PresetEntry = z.infer<typeof PresetEntrySchema>;
+type PresetFile = z.infer<typeof PresetFileSchema>;
 
 export const PRESET_FILE_PATH = ".rethunk/git-mcp-presets.json";
 
-export type PresetLoadFail =
+type PresetLoadFail =
   | { ok: false; reason: "missing" }
   | { ok: false; reason: "invalid_json"; message: string }
   | { ok: false; reason: "schema"; issues: z.ZodIssue[] };
 
-export type PresetLoadOk = { ok: true; data: PresetFile; schemaVersion?: string };
+type PresetLoadOk = { ok: true; data: PresetFile; schemaVersion?: string };
 
-export type PresetLoadResult = PresetLoadOk | PresetLoadFail;
+type PresetLoadResult = PresetLoadOk | PresetLoadFail;
 
 /**
  * Supports:
  * - Wrapped: `{ "schemaVersion": "1", "presets": { "name": { ... } } }`
  * - Legacy: `{ "name": { ... }, ... }` with optional top-level `schemaVersion` / `$schema` (editor hints).
  */
-export function splitPresetFileRaw(raw: unknown): { mapRaw: unknown; schemaVersion?: string } {
+function splitPresetFileRaw(raw: unknown): { mapRaw: unknown; schemaVersion?: string } {
   if (raw === null || typeof raw !== "object" || Array.isArray(raw)) {
     throw new Error("invalid_root");
   }
@@ -121,7 +121,7 @@ export function presetLoadErrorPayload(
   return { error: "preset_file_invalid", presetFile };
 }
 
-export function getPresetEntry(
+function getPresetEntry(
   gitTop: string,
   presetName: string,
 ):
@@ -155,7 +155,7 @@ export function getPresetEntry(
   return { ok: true, entry, presetSchemaVersion: loaded.schemaVersion };
 }
 
-export function mergeNestedRoots(
+function mergeNestedRoots(
   preset: string[] | undefined,
   inline: string[] | undefined,
 ): string[] | undefined {
@@ -173,7 +173,7 @@ export function mergeNestedRoots(
   return out;
 }
 
-export function mergePairs<T extends { left: string; right: string; label?: string }>(
+function mergePairs<T extends { left: string; right: string; label?: string }>(
   preset: T[] | undefined,
   inline: T[] | undefined,
 ): T[] | undefined {

src/server/roots.ts

@@ -6,7 +6,7 @@ import type { FastMCP } from "fastmcp";
 import { gateGit, gitTopLevel } from "./git.js";
 import { loadPresetsFromGitTop, presetLoadErrorPayload } from "./presets.js";
 
-export function uriToPath(uri: string): string | null {
+function uriToPath(uri: string): string | null {
   if (!uri.startsWith("file://")) return null;
   try {
     return fileURLToPath(uri);
@@ -15,7 +15,7 @@ export function uriToPath(uri: string): string | null {
   }
 }
 
-export function listFileRoots(server: FastMCP): string[] {
+function listFileRoots(server: FastMCP): string[] {
   const sessions = server.sessions;
   const roots = sessions[0]?.roots ?? [];
   const paths: string[] = [];
@@ -27,7 +27,7 @@ export function listFileRoots(server: FastMCP): string[] {
 }
 
 /** Basename or trailing path segment; compares using normalized slashes so Windows backslashes match. */
-export function pathMatchesWorkspaceRootHint(rootPath: string, hint: string): boolean {
+function pathMatchesWorkspaceRootHint(rootPath: string, hint: string): boolean {
   const h = hint.trim();
   if (!h) return true;
   const absRoot = resolve(rootPath);
@@ -39,17 +39,17 @@ export function pathMatchesWorkspaceRootHint(rootPath: string, hint: string): bo
   return basename(rootPath) === h;
 }
 
-export type RootPick = {
+type RootPick = {
   workspaceRoot?: string;
   rootIndex?: number;
   allWorkspaceRoots?: boolean;
 };
 
-export type ResolveRootsResult =
+type ResolveRootsResult =
   | { ok: true; roots: string[] }
   | { ok: false; error: Record<string, unknown> };
 
-export function resolveWorkspaceRoots(server: FastMCP, args: RootPick): ResolveRootsResult {
+function resolveWorkspaceRoots(server: FastMCP, args: RootPick): ResolveRootsResult {
   if (args.workspaceRoot?.trim()) {
     return { ok: true, roots: [resolve(args.workspaceRoot.trim())] };
   }
@@ -80,7 +80,7 @@ export function resolveWorkspaceRoots(server: FastMCP, args: RootPick): ResolveR
  * When a preset name is requested and multiple MCP roots exist, pick the first root
  * whose git toplevel loads a preset file containing that name.
  */
-export function resolveRootsForPreset(
+function resolveRootsForPreset(
   server: FastMCP,
   args: RootPick,
   presetName: string,
@@ -116,7 +116,7 @@ export function resolveRootsForPreset(
   return resolveWorkspaceRoots(server, args);
 }
 
-export type GitAndRootsResult =
+type GitAndRootsResult =
   | { ok: true; roots: string[] }
   | { ok: false; error: Record<string, unknown> };