when pasting a condition into an empty leaderboard editor, add measured flag to prevent serializing comparison (#1322)

Author: Jamiras

src/ui/viewmodels/TriggerViewModel.cpp

@@ -330,7 +330,17 @@ void TriggerViewModel::PasteFromClipboard()
         return;
     }
 
-    const auto nResult = AppendMemRefChain(ra::util::String::Narrow(sClipboardText));
+    std::string sNarrowText = ra::util::String::Narrow(sClipboardText);
+    if (IsValue() && Conditions().Count() == 0 && sNarrowText.find(':') == std::string::npos)
+    {
+        // if pasting something that looks like a legacy-formatted value into the value editor,
+        // and the value editor is empty, explicitly add a "M:" so it doesn't get parse as a
+        // legacy value. this prevents pushing a legacy value with a comparison to the server,
+        // which can prevent the leaderboard from functioning in rcheevos 12.0 and 12.1.
+        sNarrowText.insert(0, "M:");
+    }
+
+    const auto nResult = AppendMemRefChain(sNarrowText);
     if (nResult != RC_OK)
     {
         if (nResult == RC_MULTIPLE_GROUPS)

tests/ui/viewmodels/TriggerViewModel_Tests.cpp

@@ -574,6 +574,23 @@ TEST_CLASS(TriggerViewModel_Tests)
         Assert::IsTrue(bDialogShown);
     }
 
+    TEST_METHOD(TestPasteFromClipboardValueWithComparison)
+    {
+        TriggerViewModelHarness vmTrigger;
+        Parse(vmTrigger, "");
+        vmTrigger.SetIsValue(true);
+
+        vmTrigger.mockClipboard.SetText(L"0xH1234<100");
+        vmTrigger.PasteFromClipboard();
+
+        // the parser will see "0xH1234<100" as a legacy value and truncate it to "0xH1234" for display.
+        // but the serialized value will still have the "<100" as it was part of the pasted text.
+        // expect the paste operation to convert it to a non-legacy value
+
+        Assert::AreEqual({ 1U }, vmTrigger.Conditions().Count());
+        Assert::AreEqual(std::string("M:0xH1234<100"), vmTrigger.Serialize());
+    }
+
     TEST_METHOD(TestPasteFromClipboardInvalidSyntax)
     {
         TriggerViewModelHarness vmTrigger;