fix: add missing destructor in DirectoryStorage to free mFileHierarchy

jolavillette · jolavillette · commit 783bc8051df4 · 2026-05-05T04:36:39.000+02:00
diff --git a/src/file_sharing/directory_storage.cc b/src/file_sharing/directory_storage.cc
@@ -99,6 +99,10 @@ DirectoryStorage::DirectoryStorage(const RsPeerId &pid,const std::string& fname)
 	}
     load(fname) ;
 }
+DirectoryStorage::~DirectoryStorage()
+{
+	delete mFileHierarchy;
+}
 
 DirectoryStorage::EntryIndex DirectoryStorage::root() const
 {
diff --git a/src/file_sharing/directory_storage.h b/src/file_sharing/directory_storage.h
@@ -39,7 +39,7 @@ class DirectoryStorage
 {
 	public:
         DirectoryStorage(const RsPeerId& pid, const std::string& fname) ;
-        virtual ~DirectoryStorage() {}
+        virtual ~DirectoryStorage() ;
 
         typedef uint32_t EntryIndex ;
         static const EntryIndex NO_INDEX = 0xffffffff;

Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,10 @@ DirectoryStorage::DirectoryStorage(const RsPeerId &pid,const std::string& fname)`
`99`	`99`	`}`
`100`	`100`	`load(fname) ;`
`101`	`101`	`}`
	`102`	`+DirectoryStorage::~DirectoryStorage()`
	`103`	`+{`
	`104`	`+ delete mFileHierarchy;`
	`105`	`+}`
`102`	`106`
`103`	`107`	`DirectoryStorage::EntryIndex DirectoryStorage::root() const`
`104`	`108`	`{`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ class DirectoryStorage`
`39`	`39`	`{`
`40`	`40`	`public:`
`41`	`41`	`DirectoryStorage(const RsPeerId& pid, const std::string& fname) ;`
`42`		`- virtual ~DirectoryStorage() {}`
	`42`	`+ virtual ~DirectoryStorage() ;`
`43`	`43`
`44`	`44`	`typedef uint32_t EntryIndex ;`
`45`	`45`	`static const EntryIndex NO_INDEX = 0xffffffff;`