Skip to content

fix: add missing destructor in DirectoryStorage to free mFileHierarchy #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csoler merged 1 commit into from
May 15, 2026
+6 −1
Merged

fix: add missing destructor in DirectoryStorage to free mFileHierarchy #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/file_sharing/directory_storage.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@ DirectoryStorage::DirectoryStorage(const RsPeerId &pid,const std::string& fname)
load(fname) ;
}

DirectoryStorage::~DirectoryStorage()
{
delete mFileHierarchy;
}

DirectoryStorage::EntryIndex DirectoryStorage::root() const
{
return EntryIndex(0) ;
Expand Down
2 changes: 1 addition & 1 deletion src/file_sharing/directory_storage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class DirectoryStorage
{
public:
DirectoryStorage(const RsPeerId& pid, const std::string& fname) ;
virtual ~DirectoryStorage() {}
virtual ~DirectoryStorage();

typedef uint32_t EntryIndex ;
static const EntryIndex NO_INDEX = 0xffffffff;
Expand Down
Loading