Added auth token fix for retroshare mobile#336
Open
defnax wants to merge 2 commits into
Open
Conversation
Contributor
Author
Contributor
Author
|
Hope merged soon i need continue on retroshare mobile |
G10h4ck
requested changes
Jul 20, 2026
Contributor
|
did you test it on at least a couple of platforms? |
Contributor
Author
|
i tesed with rs mobile flutter with windows desktop(w10) and android (Samsung) no issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Walkthrough - Secure API Token Authentication
We have designed and implemented a safer authentication mechanism for RetroShare's JSON API. The PGP/profile password is no longer transmitted in the Authorization headers of REST requests, nor is it registered as the API token. Instead, we dynamically derive a secure API token client-side and authorize it upon login.
Changes
1. C++ Core (libretroshare)
attemptLoginasmanualwrapperto exclude it from automatic API wrapper generation./rsLoginHelper/attemptLoginthat deserializes optionalapiUserandapiPassfields, callsattemptLogin, and registers the client's custom credentials usingauthorizeUser(apiUser, apiPass)if the login is successful.2. Dart API Wrapper (Retroshare-Wrapper)
requestLogInandrequestAccountCreationto accept optionalapiUserandapiPassarguments and include them in the request body parameters.3. Mobile Client (rs-mobile)
cryptopackage dependency.deriveApiTokenhelper function usingsha256(locationId:password)to dynamically compute secure API credentials.getinitializeAuthto verify credentials usingderiveApiToken.loginandsignupmethods to derive the secure credentials and pass them during registration/login calls.Verification Results
flutter pub get.