Skip to content

refactor(mobile): 清償技術債（手勢/API重試/元件拆分/ErrorBoundary）+ 修正合圖姓名殘留與 Andro… #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Retsomm merged 4 commits into from
Jul 22, 2026
Merged

refactor(mobile): 清償技術債（手勢/API重試/元件拆分/ErrorBoundary）+ 修正合圖姓名殘留與 Andro… #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85221fa
refactor(mobile): 清償技術債（手勢/API重試/元件拆分/ErrorBoundary）+ 修正合圖姓名殘留與 Andro…
Retsomm Jul 21, 2026
a6de496
fix(mobile): 修正出生資料選單背景遮罩、Hermes 重試判斷與流日資料 fallback
Retsomm Jul 21, 2026
17bf9be
refactor: 抽出 web/mobile 重複的人類圖顯示資料至 shared/humanDesign/
Retsomm Jul 22, 2026
be872f6
fix(humanDesign): 修正圖表切換競態、圖例配色/整合通道重複資料與內容不一致
Retsomm Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/api/aura-flow/live-svg/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
ACT_CONSCIOUS,
ACT_UNCONSCIOUS,
INTEGRATION_PAIRS,
} from '@/components/humanDesign/hd-chart-data'
} from '@/shared/humanDesign/hd-chart-data'

// Lib CenterName uses 'ego' / 'solarPlexus'; chart data uses 'heart' / 'solar'
const LIB_TO_CHART: Record<string, string> = { ego: 'heart', solarPlexus: 'solar' }
Expand Down
2 changes: 1 addition & 1 deletion components/humanDesign/BodyGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
ACT_CONSCIOUS,
ACT_UNCONSCIOUS,
type ChartChannel,
} from './hd-chart-data'
} from '@/shared/humanDesign/hd-chart-data'

export type { GateActivation, Activations }

Expand Down
2 changes: 1 addition & 1 deletion components/humanDesign/ChartView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import PlanetIcon from '@/components/humanDesign/PlanetIcon'
import { fmtGate, fmtCenterName } from '@/utils/format'
import BodyGraph, { type SelectionPayload, type AnnotationLabels } from '@/components/humanDesign/BodyGraph'
import DetailDrawer from '@/components/humanDesign/DetailDrawer'
import { HD_GATES, HD_CENTERS_INFO, HD_CHANNELS } from '@/components/humanDesign/hd-chart-data'
import { HD_GATES, HD_CENTERS_INFO, HD_CHANNELS } from '@/shared/humanDesign/hd-chart-data'
import {
CENTER_INFO,
CHANNEL_DEFS,
Expand Down
31 changes: 15 additions & 16 deletions components/humanDesign/DetailDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

import { useEffect, useState } from 'react'
import { fmtGate } from '@/utils/format'
import { HD_GATES, HD_CENTERS_INFO, type ChartChannel } from './hd-chart-data'
import { HD_GATES, HD_CENTERS_INFO, HD_CHANNELS, INTEGRATION_PAIRS, type ChartChannel } from '@/shared/humanDesign/hd-chart-data'
import type { SelectionPayload } from './BodyGraph'
import { HD_TYPE_CONTENT, HD_PROFILE_CONTENT, HD_AUTHORITY_CONTENT, HD_DEFINITION_CONTENT } from './hd-summary-data'
import type { GateCrossData } from './hd-cross-data'
import { HD_TYPE_CONTENT, HD_PROFILE_CONTENT, HD_AUTHORITY_CONTENT, HD_DEFINITION_CONTENT } from '@/shared/humanDesign/hd-summary-data'
import type { GateCrossData } from '@/shared/humanDesign/hd-cross-data'

interface DetailDrawerProps {
selection: SelectionPayload | null
Expand All @@ -20,7 +20,7 @@ export default function DetailDrawer({ selection, onClose, onJumpToGate }: Detai
useEffect(() => {
if (selection?.kind !== 'cross' || crossContent) return
let cancelled = false
import('./hd-cross-data').then(m => {
import('@/shared/humanDesign/hd-cross-data').then(m => {
if (!cancelled) setCrossContent(m.HD_CROSS_CONTENT)
})
return () => { cancelled = true }
Expand Down Expand Up @@ -146,26 +146,25 @@ export default function DetailDrawer({ selection, onClose, onJumpToGate }: Detai
</>
)
} else if (kind === 'integration') {
const integrationList = [
{ a: 10, b: 20, name: { zh: '覺醒通道', en: 'Awakening' }, desc: { zh: '你對「真不真實」有一種近乎本能的敏感，要求自己活得誠實有原則，這種處世態度讓身邊的人不自覺開始思考「我是不是也可以更做自己一點」。你只在乎「當下」，這種活在當下的能量是你給周圍人最大的禮物之一。', en: 'Awakening to self — authentic expression in the now.' } },
{ a: 10, b: 34, name: { zh: '探索通道', en: 'Exploration' }, desc: { zh: '你就是要走自己的路，當你按照自己的感覺和直覺行動，你會感覺對了、有力量。這條通道有個特別能量：當你真的活出自己的樣子，你身邊的人也會被感染，開始有勇氣去做自己。', en: "Acting in accordance with one's own convictions." } },
{ a: 10, b: 57, name: { zh: '生存力通道', en: 'Perfected Form' }, desc: { zh: '你有一種很難用邏輯解釋的化險為夷能力，脾中心有一套超靈敏的生存雷達，在危險靠近之前就悄悄提醒你。你的直覺靠「聽起來對不對」來判斷，前提是你要願意相信它。', en: "Intuition of one's own survival and self-expression." } },
{ a: 20, b: 34, name: { zh: '忙碌通道', en: 'Charisma' }, desc: { zh: '當你找到一件真心喜歡的事，你會整個人燃起來，精力充沛停不下來，旁邊的人光看著你就會被帶動。但不是每一件事都值得你去忙——只為你愛的事忙，才是這條通道最美的狀態。', en: 'The present-moment exhibitor. The power of being busy in the now.' } },
{ a: 34, b: 57, name: { zh: '力量通道', en: 'Power' }, desc: { zh: '這條通道讓你天生精力充沛，在關鍵時刻反應特別快特別準，在危機處理上特別厲害。你很自然地想替人療傷解決問題，但要先照顧好自己才能照顧好別人，選擇值得你投入力量的人和事。', en: 'Archetypal existence — perfect survival intuition.' } },
]
// 六條整合通道皆已存在於 HD_CHANNELS，直接依 INTEGRATION_PAIRS 篩選，
// 不重複維護一份名稱/說明；20-57 是複合圖形的主幹（trunk），與其餘四條
// 支線（10-20/10-34/10-57/20-34/34-57）並列顯示，不特別區分。
const integrationChannels = Array.from(INTEGRATION_PAIRS)
.map(pairId => HD_CHANNELS.find(ch => `${ch.from}-${ch.to}` === pairId))
.filter((ch): ch is ChartChannel => !!ch)
Comment on lines +149 to +154

@coderabbitai coderabbitai Bot Jul 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Extract the integration-channel resolution into a reusable helper.

The pair-to-channel lookup is a distinct functionality but is implemented inline in the render branch. Move it to a named, documented helper and test the canonical from-to mapping independently.

As per coding guidelines, each functionality should be implemented as an independent, reusable function with complete comments including calculation principles.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@components/humanDesign/DetailDrawer.tsx` around lines 149 - 154, Extract the
inline INTEGRATION_PAIRS-to-HD_CHANNELS lookup from the render branch into a
named, documented reusable helper, preserving the canonical `${from}-${to}`
matching and omission of unresolved channels. Add focused tests for the helper’s
canonical from-to mapping, and document its calculation principle.

Source: Coding guidelines

kicker = '整合'
title = '整合通道'
sub = '四條整合通道'
sub = `${integrationChannels.length} 條整合通道`
body = (
<>
<p className="lead">這些通道代表你整體的整合力量與表達方式。</p>
<h4>四條主要通道</h4>
<h4>{integrationChannels.length} 條主要通道</h4>
<div style={{ display: 'flex', flexDirection: 'column', gap: 10 }}>
{integrationList.map(ch => (
<div key={`${ch.a}-${ch.b}`} className="hd-ch-card">
{integrationChannels.map(ch => (
<div key={ch.id} className="hd-ch-card">
<div className="hd-ch-card-head">
<span className="hd-ch-card-title">{pick(ch.name)}</span>
<span className="hd-ch-card-ref">CH.{ch.a}—{ch.b}</span>
<span className="hd-ch-card-ref">CH.{ch.from}—{ch.to}</span>
</div>
<p style={{ margin: 0, fontSize: 13, lineHeight: 1.55 }}>{pick(ch.desc)}</p>
</div>
Expand Down
Loading