Replace boost::optional by std::optional

Author: Flamefire

extras/ai-battle/main.cpp

@@ -16,8 +16,14 @@
 #include <boost/nowide/args.hpp>
 #include <boost/nowide/filesystem.hpp>
 #include <boost/nowide/iostream.hpp>
-#include <boost/optional.hpp>
 #include <boost/program_options.hpp>
+#if BOOST_VERSION >= 109000
+#    include <optional>
+using std::optional;
+#else
+#    include <boost/optional.hpp>
+using boost::optional;
+#endif
 
 namespace bnw = boost::nowide;
 namespace bfs = boost::filesystem;
@@ -28,8 +34,8 @@ int main(int argc, char** argv)
     bnw::nowide_filesystem();
     bnw::args _(argc, argv);
 
-    boost::optional<std::string> replay_path;
-    boost::optional<std::string> savegame_path;
+    optional<std::string> replay_path;
+    optional<std::string> savegame_path;
     unsigned random_init = static_cast<unsigned>(std::chrono::high_resolution_clock::now().time_since_epoch().count());
     unsigned random_ai_init = random_init;
 

libs/common/include/helpers/OptionalEnum.h

@@ -5,9 +5,8 @@
 #pragma once
 
 #include "MaxEnumValue.h"
-#include <boost/none.hpp>
-#include <boost/optional/bad_optional_access.hpp>
 #include <limits>
+#include <optional>
 #include <type_traits>
 
 namespace helpers {
@@ -26,7 +25,7 @@ class OptionalEnum
     using value_type = T;
 
     constexpr OptionalEnum() noexcept = default;
-    OptionalEnum(boost::none_t) noexcept {}
+    OptionalEnum(std::nullopt_t) noexcept {}
     constexpr OptionalEnum(const T& value) noexcept : value_(static_cast<underlying_type>(value)) {}
     constexpr OptionalEnum& operator=(const T& value) noexcept
     {
@@ -41,7 +40,7 @@ class OptionalEnum
     constexpr T value() const
     {
         if(!has_value())
-            throw boost::bad_optional_access();
+            throw std::bad_optional_access();
         return **this;
     }
     constexpr T value_or(T default_value) const { return bool(*this) ? **this : default_value; }

libs/common/include/helpers/optional_io.h

@@ -0,0 +1,29 @@
+// Copyright (C) 2005 - 2026 Settlers Freaks (sf-team at siedler25.org)
+//
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+#pragma once
+
+#include <boost/test/tools/detail/print_helper.hpp>
+#include <optional>
+#include <ostream>
+
+template<class CharType, class CharTrait, class T>
+inline std::basic_ostream<CharType, CharTrait>& operator<<(std::basic_ostream<CharType, CharTrait>& out,
+                                                           std::optional<T> const& v)
+{
+    return out << (v ? *v : "--");
+}
+namespace boost::test_tools::tt_detail {
+template<typename T>
+struct print_log_value<std::optional<T>>
+{
+    void operator()(std::ostream& os, std::optional<T> const& v)
+    {
+        if(v)
+            os << *v;
+        else
+            os << "<nullopt>";
+    }
+};
+} // namespace boost::test_tools::tt_detail

libs/s25main/BuildingRegister.cpp

@@ -157,7 +157,7 @@ helpers::EnumArray<uint16_t, BuildingType> BuildingRegister::CalcProductivities(
 
 unsigned BuildingRegister::CalcAverageProductivity(BuildingType bldType) const
 {
-    if(holds_alternative<boost::none_t>(BLD_WORK_DESC[bldType].producedWare))
+    if(holds_alternative<std::nullopt_t>(BLD_WORK_DESC[bldType].producedWare))
         return 0;
     unsigned productivity = 0;
     const auto& buildings = GetBuildings(bldType);
@@ -177,7 +177,7 @@ unsigned short BuildingRegister::CalcAverageProductivity() const
     unsigned numBlds = 0;
     for(const auto bldType : helpers::enumRange<BuildingType>())
     {
-        if(holds_alternative<boost::none_t>(BLD_WORK_DESC[bldType].producedWare))
+        if(holds_alternative<std::nullopt_t>(BLD_WORK_DESC[bldType].producedWare))
             continue;
 
         const auto& buildings = GetBuildings(bldType);

libs/s25main/EconomyModeHandler.cpp

@@ -16,8 +16,8 @@
 #include "gameTypes/JobTypes.h"
 #include "gameData/GoodConsts.h"
 #include "gameData/JobConsts.h"
-#include <boost/optional.hpp>
 #include <array>
+#include <optional>
 
 EconomyModeHandler::EconomyModeHandler(unsigned endFrame) : endFrame(endFrame), gfLastUpdated(0)
 {
@@ -151,7 +151,7 @@ unsigned EconomyModeHandler::SumUpGood(GoodType good, const Inventory& Inventory
     // Add the tools used by workers to the good totals
     for(const auto j : helpers::enumRange<Job>())
     {
-        boost::optional<GoodType> tool = JOB_CONSTS[j].tool;
+        std::optional<GoodType> tool = JOB_CONSTS[j].tool;
         if(tool == good)
         {
             retVal += Inventory.people[j];

libs/s25main/Game.cpp

@@ -13,7 +13,7 @@
 #include "lua/LuaInterfaceGame.h"
 #include "network/GameClient.h"
 #include "gameData/GameConsts.h"
-#include <boost/optional.hpp>
+#include <optional>
 
 Game::Game(GlobalGameSettings settings, unsigned startGF, const std::vector<PlayerInfo>& players)
     : Game(std::move(settings), std::make_unique<EventManager>(startGF), players)
@@ -113,7 +113,7 @@ void Game::CheckObjective()
         return;
 
     unsigned maxPoints = 0, maxTeamPoints = 0, totalPoints = 0, bestPlayer = 0;
-    boost::optional<unsigned> bestTeam;
+    std::optional<unsigned> bestTeam;
 
     const auto getPlayerMask = [](unsigned playerId) { return 1u << playerId; };
 

libs/s25main/GameManager.h

@@ -5,7 +5,7 @@
 #pragma once
 
 #include "FrameCounter.h"
-#include <boost/optional.hpp>
+#include <optional>
 
 class Log;
 class Settings;
@@ -46,7 +46,7 @@ class GameManager
     {
         unsigned time, gf;
     };
-    boost::optional<SkipReport> lastSkipReport;
+    std::optional<SkipReport> lastSkipReport;
 };
 
 GameManager& getGlobalGameManager();

libs/s25main/Pathfinding.cpp

@@ -24,7 +24,7 @@ helpers::OptionalEnum<Direction> GameWorldBase::FindHumanPath(const MapPoint sta
                                     PathConditionHuman(*this)))
         return first_dir;
     else
-        return boost::none;
+        return std::nullopt;
 }
 
 /// Wegfindung für Menschen im Straßennetz
@@ -102,19 +102,19 @@ helpers::OptionalEnum<Direction> GameWorld::FindTradePath(const MapPoint start,
 {
     unsigned char owner = GetNode(dest).owner;
     if(owner != 0 && !GetPlayer(player).IsAlly(owner - 1))
-        return boost::none;
+        return std::nullopt;
 
     RTTR_Assert(GetNO(dest)->GetType() == NodalObjectType::Flag); // Goal should be the flag of a wh
 
     if(!PathConditionHuman(*this).IsNodeOk(dest))
-        return boost::none;
+        return std::nullopt;
 
     Direction first_dir{};
     if(GetFreePathFinder().FindPath(start, dest, random_route, max_route, route, length, &first_dir,
                                     PathConditionTrade(*this, player)))
         return first_dir;
     else
-        return boost::none;
+        return std::nullopt;
 }
 
 bool GameWorld::CheckTradeRoute(const MapPoint start, const std::vector<Direction>& route, unsigned pos,

libs/s25main/Settings.cpp

@@ -60,13 +60,13 @@ const std::map<GUI_ID, std::string> persistentWindows = {{CGI_CHAT, "wnd_chat"},
                                                          {CGI_MERCHANDISE_STATISTICS, "wnd_merchandise_statistics"}};
 
 namespace validate {
-boost::optional<uint16_t> checkPort(const std::string& port)
+std::optional<uint16_t> checkPort(const std::string& port)
 {
     int32_t iPort;
     if((helpers::tryFromString(port, iPort) || s25util::tryFromStringClassic(port, iPort)) && checkPort(iPort))
         return static_cast<uint16_t>(iPort);
     else
-        return boost::none;
+        return std::nullopt;
 }
 bool checkPort(int port)
 {
@@ -309,7 +309,7 @@ void Settings::Load()
         // server
         // {
         server.lastIP = iniServer->getValue("last_ip");
-        boost::optional<uint16_t> port = validate::checkPort(iniServer->getValue("local_port"));
+        std::optional<uint16_t> port = validate::checkPort(iniServer->getValue("local_port"));
         server.localPort = port.value_or(3665);
         server.ipv6 = iniServer->getBoolValue("ipv6");
         // }

libs/s25main/Settings.h

@@ -9,17 +9,17 @@
 #include "driver/VideoMode.h"
 #include "s25util/ProxySettings.h"
 #include "s25util/Singleton.h"
-#include <boost/optional.hpp>
 #include <array>
 #include <cstdint>
 #include <gameData/const_gui_ids.h>
 #include <map>
+#include <optional>
 #include <string>
 
 #undef interface
 
 namespace validate {
-boost::optional<uint16_t> checkPort(const std::string& port);
+std::optional<uint16_t> checkPort(const std::string& port);
 bool checkPort(int port);
 } // namespace validate