Allow excluding windows from being closed via Esc

Add a "pin" function to in-game windows. The function replaces the shade
(aka. minimize) button and the window can instead be shaded by
double-clicking the title bar. Pinned windows are excluded from being
closed by the window manager when hitting the Escape key.

Author: falbrechtskirchinger

libs/s25main/WindowManager.cpp

@@ -132,11 +132,14 @@ void WindowManager::RelayKeyboardMessage(KeyboardMsgHandler msg, const KeyEvent&
         return; // No windows -> nothing to do
 
     // ESC or ALT+W closes the active window
-    if(ke.kt == KeyType::Escape || (ke.c == 'w' && ke.alt))
+    const auto escape = (ke.kt == KeyType::Escape);
+    if(escape || (ke.c == 'w' && ke.alt))
     {
         // Find one which isn't yet marked for closing so multiple ESC in between draw calls can close multiple windows
-        const auto itActiveWnd =
-          std::find_if(windows.rbegin(), windows.rend(), [](const auto& wnd) { return !wnd->ShouldBeClosed(); });
+        // ESC won't close pinned windows
+        const auto itActiveWnd = std::find_if(windows.rbegin(), windows.rend(), [escape](const auto& wnd) {
+            return !wnd->ShouldBeClosed() && !(escape && wnd->IsPinned());
+        });
         if(itActiveWnd != windows.rend() && (*itActiveWnd)->getCloseBehavior() != CloseBehavior::Custom)
             (*itActiveWnd)->Close();
     } else if(!CALL_MEMBER_FN(*windows.back(), msg)(ke)) // send to active window

libs/s25main/ingameWindows/IngameWindow.cpp

@@ -22,7 +22,8 @@
 
 namespace {
 constexpr Extent ButtonSize(16, 16);
-}
+constexpr unsigned TitleMargin = 32;
+} // namespace
 
 const DrawPoint IngameWindow::posLastOrCenter(std::numeric_limits<DrawPoint::ElementType>::max(),
                                               std::numeric_limits<DrawPoint::ElementType>::max());
@@ -35,7 +36,8 @@ const Extent IngameWindow::borderSize(1, 1);
 IngameWindow::IngameWindow(unsigned id, const DrawPoint& pos, const Extent& size, std::string title,
                            glArchivItem_Bitmap* background, bool modal, CloseBehavior closeBehavior, Window* parent)
     : Window(parent, id, pos, size), title_(std::move(title)), background(background), lastMousePos(0, 0),
-      isModal_(modal), closeme(false), isMinimized_(false), isMoving(false), closeBehavior_(closeBehavior)
+      isModal_(modal), closeme(false), isPinned_(false), isMinimized_(false), isMoving(false),
+      closeBehavior_(closeBehavior)
 {
     std::fill(buttonStates_.begin(), buttonStates_.end(), ButtonState::Up);
     contentOffset.x = LOADER.GetImageN("resource", 38)->getWidth();     // left border
@@ -180,17 +182,32 @@ void IngameWindow::MouseLeftUp(const MouseCoords& mc)
         buttonStates_[btn] = ButtonState::Up;
 
         if((btn == IwButton::Close && closeBehavior_ == CloseBehavior::Custom) // no close button
-           || (btn == IwButton::Minimize && isModal_))                         // modal windows cannot be minimized
+           || (isModal_ // modal windows cannot be pinned or minimized
+               && (btn == IwButton::Title || btn == IwButton::PinOrMinimize)))
             continue;
 
         if(IsPointInRect(mc.GetPos(), GetButtonBounds(btn)))
         {
             switch(btn)
             {
                 case IwButton::Close: Close(); break;
-                case IwButton::Minimize:
-                    SetMinimized(!IsMinimized());
-                    LOADER.GetSoundN("sound", 113)->Play(255, false);
+                case IwButton::Title:
+                    if(SETTINGS.interface.enableWindowPinning && mc.dbl_click)
+                    {
+                        SetMinimized(!IsMinimized());
+                        LOADER.GetSoundN("sound", 113)->Play(255, false);
+                    }
+                    break;
+                case IwButton::PinOrMinimize:
+                    if(SETTINGS.interface.enableWindowPinning)
+                    {
+                        SetPinned(!IsPinned());
+                        LOADER.GetSoundN("sound", 111)->Play(255, false);
+                    } else
+                    {
+                        SetMinimized(!IsMinimized());
+                        LOADER.GetSoundN("sound", 113)->Play(255, false);
+                    }
                     break;
             }
         }
@@ -263,11 +280,27 @@ void IngameWindow::Draw_()
     using ButtonStateResIds = helpers::EnumArray<unsigned, ButtonState>;
     constexpr ButtonStateResIds closeResIds = {47, 55, 51};
     constexpr ButtonStateResIds minimizeResIds = {48, 56, 52};
+    constexpr ButtonStateResIds pinBaseResIds = {47, 47, 51};
+    constexpr auto overlayIdsStart = 15u;
+    constexpr ButtonStateResIds pinOverlayResIdsRel = {0, 1, 2};
+    constexpr ButtonStateResIds unpinOverlayResIdsRel = {3, 4, 5};
     if(closeBehavior_ != CloseBehavior::Custom)
-        LOADER.GetImageN("resource", closeResIds[buttonStates_[IwButton::Close]])->DrawFull(GetPos());
+        LOADER.GetImageN("resource", closeResIds[buttonStates_[IwButton::Close]])
+          ->DrawFull(GetButtonBounds(IwButton::Close));
     if(!IsModal())
-        LOADER.GetImageN("resource", minimizeResIds[buttonStates_[IwButton::Minimize]])
-          ->DrawFull(GetButtonBounds(IwButton::Minimize));
+    {
+        const auto buttonState = buttonStates_[IwButton::PinOrMinimize];
+        const auto bounds = GetButtonBounds(IwButton::PinOrMinimize);
+        if(SETTINGS.interface.enableWindowPinning)
+        {
+            LOADER.GetImageN("resource", pinBaseResIds[buttonState])->DrawFull(bounds);
+            if(isPinned_)
+                LOADER.GetImageN("io_new", unpinOverlayResIdsRel[buttonState] + overlayIdsStart)->DrawFull(bounds);
+            else
+                LOADER.GetImageN("io_new", pinOverlayResIdsRel[buttonState] + overlayIdsStart)->DrawFull(bounds);
+        } else
+            LOADER.GetImageN("resource", minimizeResIds[buttonState])->DrawFull(bounds);
+    }
 
     // The title bar
     unsigned titleIndex;
@@ -379,10 +412,15 @@ void IngameWindow::SaveOpenStatus(bool isOpen) const
 Rect IngameWindow::GetButtonBounds(IwButton btn) const
 {
     auto pos = GetPos();
+    auto size = ButtonSize;
     switch(btn)
     {
         case IwButton::Close: break;
-        case IwButton::Minimize: pos.x += GetSize().x - ButtonSize.x; break;
+        case IwButton::Title:
+            pos.x += TitleMargin;
+            size.x = GetSize().x - TitleMargin * 2;
+            break;
+        case IwButton::PinOrMinimize: pos.x += GetSize().x - ButtonSize.x; break;
     }
-    return Rect(pos, ButtonSize);
+    return Rect(pos, size);
 }

libs/s25main/ingameWindows/IngameWindow.h

@@ -29,11 +29,12 @@ enum CloseBehavior
 enum class IwButton
 {
     Close,
-    Minimize
+    Title, /// Pseudo-button to respond to double-clicks on the title bar
+    PinOrMinimize
 };
 constexpr auto maxEnumValue(IwButton)
 {
-    return IwButton::Minimize;
+    return IwButton::PinOrMinimize;
 }
 
 class IngameWindow : public Window
@@ -83,6 +84,9 @@ class IngameWindow : public Window
     /// ist das Fenster minimiert?
     bool IsMinimized() const { return isMinimized_; }
 
+    void SetPinned(bool pinned = true) { isPinned_ = pinned; }
+    bool IsPinned() const { return isPinned_; }
+
     CloseBehavior getCloseBehavior() const { return closeBehavior_; }
 
     /// Modal windows cannot be minimized, are always active and stay on top of non-modal ones
@@ -123,6 +127,7 @@ class IngameWindow : public Window
 
     bool isModal_;
     bool closeme;
+    bool isPinned_;
     bool isMinimized_;
     bool isMoving;
     CloseBehavior closeBehavior_;