Radius overlay#1946
Draft
morganchristiansson wants to merge 9 commits into
Draft
Conversation
Flamefire
requested changes
Jun 15, 2026
Comment on lines
+768
to
+780
| // Draw at all 9 toroidal copies (canonical ± 1 map dimension). | ||
| // Using all copies guarantees the ring is continuous across the seam | ||
| // regardless of viewport position — the renderer clips off-screen pixels. | ||
| for(int dw : {-w, 0, w}) | ||
| { | ||
| for(int dh : {-h, 0, h}) | ||
| { | ||
| const MapPoint copyPt = MakeMapPoint(Position(basePt.x + dw, basePt.y + dh), mapSize); | ||
| const auto alt = world.GetNode(copyPt).altitude; | ||
| const DrawPoint scr = GetNodePos(copyPt) - DrawPoint(0, HEIGHT_FACTOR * alt) - offset; | ||
| Window::DrawRectangle(Rect(scr - DrawPoint(2, 2), Extent(5, 5)), BORDER_COLOR); | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
Noone commented on this yet.
The drawn radius was being clipped where map repeats and this is a workaround. Did not find any cleaner way advise appreciated.
| @@ -132,16 +132,14 @@ void nofHunter::HandleDerivedEvent(unsigned /*id*/) | |||
| void nofHunter::TryStartHunting() | |||
| { | |||
| // Find animals in a square around building (actually should be circle, but animals are moving anyway) | |||
Author
There was a problem hiding this comment.
Uhm hunters look for animals in a SQUARE?
Should fix to be circle? Kinda out of scope but can include or do separate PR. Cause right now the range outline doesn't match what game uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tooltip and overlay for building ranges