Skip to content

Commit adc0fec

Browse files
committed
dont close listener explicitly, just check in Accept
1 parent 6af37bc commit adc0fec

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

pkg/portforward/portforward.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package portforward
22

33
import (
44
"context"
5+
"errors"
56
"fmt"
67
"io"
78
"net"
@@ -128,7 +129,6 @@ func NewCommand() *cobra.Command {
128129
if err != nil {
129130
panic(err)
130131
}
131-
defer listener.Close()
132132
ctx, cancel := context.WithCancel(context.Background())
133133
defer cancel()
134134
go func() {
@@ -139,6 +139,9 @@ func NewCommand() *cobra.Command {
139139
default:
140140
hostConn, err := listener.Accept()
141141
if err != nil {
142+
if errors.Is(err, net.ErrClosed) {
143+
return // Prolly exiting
144+
}
142145
fmt.Printf("Accept error: %v", err)
143146
continue
144147
}

0 commit comments

Comments
 (0)