fix panic in port forward

Author: Revolyssup

Makefile

@@ -0,0 +1,3 @@
+build:
+	go build -o k8sdebug ./cmd/
+ 

cmd/main.go

@@ -18,7 +18,6 @@ func main() {
 		PersistentPostRun: func(cmd *cobra.Command, args []string) {
 			content := ""
 			content += pkg.LOGS_PATH + "=" + pkg.ConfigData.LogsPath + "\n"
-			cmd.Println(pkg.ColorLine(fmt.Sprintf("Loggger ID = %d", pkg.ConfigData.LoggerPID), pkg.ColorGreen))
 			pid, err := strconv.Atoi(strconv.Itoa(pkg.ConfigData.LoggerPID))
 			if err != nil {
 				cmd.Println("Error converting LoggerPID to string:", err)

pkg/logs/record.go

@@ -23,24 +23,52 @@ func newRecordCommand() *cobra.Command {
 		Use:   "record",
 		Short: "Record logs of a pod",
 		Args:  cobra.ExactArgs(1),
-		Run: func(cmd *cobra.Command, args []string) {
-			cmd.Println("Record command executed")
-			switch args[0] {
-			case "run":
-				startLogger()
-			case "stop":
-				stopLogger()
-			case "restart":
-				stopLogger()
-				time.Sleep(1 * time.Second) // TODO: Sync better than sleeping.
-				startLogger()
-			default:
-				cmd.Println("Invalid argument. Use 'run' or 'stop'.")
-			}
+		PreRun: func(cmd *cobra.Command, args []string) {
+			cmd.Println(pkg.ColorLine("NOTE: Currently only 1 recorder is supported at a time.", pkg.ColorYellow))
 		},
 	}
+	cmd.AddCommand(&cobra.Command{
+		Use: "run",
+		Run: func(cmd *cobra.Command, args []string) {
+			cmd.Println("Starting logger...")
+			startLogger()
+		},
+		Args:  cobra.NoArgs,
+		Short: "Start the logger",
+	})
+	cmd.AddCommand(&cobra.Command{
+		Use: "stop",
+		Run: func(cmd *cobra.Command, args []string) {
+			cmd.Println("Starting logger...")
+			stopLogger()
+		},
+		Args:  cobra.NoArgs,
+		Short: "Start the logger",
+	})
+	cmd.AddCommand(&cobra.Command{
+		Use: "restart",
+		Run: func(cmd *cobra.Command, args []string) {
+			stopLogger()
+			time.Sleep(1 * time.Second) // TODO: Sync better than sleeping.
+			startLogger()
+		},
+		Args:  cobra.NoArgs,
+		Short: "Start the logger",
+	})
 
-	cmd.Flags().StringVarP(&labels, "labels", "l", "", "list of key value pairs to use as labels while filtering pods.")
+	cmd.AddCommand(&cobra.Command{
+		Use: "status",
+		Run: func(cmd *cobra.Command, args []string) {
+			if pkg.ConfigData.LoggerPID != 0 {
+				fmt.Println("Logger is running with PID:", pkg.ConfigData.LoggerPID)
+			} else {
+				fmt.Println("Logger is not running.")
+			}
+		},
+		Args:  cobra.NoArgs,
+		Short: "Status of the logger",
+	})
+	cmd.PersistentFlags().StringVarP(&labels, "labels", "l", "", "list of key value pairs to use as labels while filtering pods.")
 	return cmd
 }
 
@@ -111,6 +139,7 @@ func stopLogger() {
 		return
 	}
 	fmt.Println("STOPPED")
+	pkg.ConfigData.LoggerPID = 0
 }
 func init() {
 	home, err := os.UserHomeDir()

pkg/portforward/portforward.go

@@ -50,6 +50,9 @@ func forwardToPod(hostConn net.Conn, podCon net.Conn) {
 
 func getPodConnection(fw forwarder.Forwarder) (net.Conn, error) {
 	port := fw.NextPort()
+	if port == "" {
+		return nil, fmt.Errorf("no available port")
+	}
 	podConn, err := net.Dial("tcp", fmt.Sprintf(":%s", port))
 	if err != nil {
 		return nil, err
@@ -60,7 +63,7 @@ func getPodConnection(fw forwarder.Forwarder) (net.Conn, error) {
 func getForwarder(policy string) forwarder.Forwarder {
 	switch policy {
 	case "round-robin":
-		return roundrobin.New(connPool)
+		return roundrobin.New(&connPool)
 	case "mock":
 		return mock.New()
 	}
@@ -153,15 +156,13 @@ func NewCommand() *cobra.Command {
 					close(stopChan)
 					delete(indexToStopChan, i)
 				}
-				fmt.Println("WILL TRY TO CREATE AT INDEX", i)
 				req := cs.CoreV1().RESTClient().Post().
 					Resource("pods").
 					Namespace(namespace).
 					Name(pod.Name).
 					SubResource("portforward")
 				transporter, upgrader, err := spdy.RoundTripperFor(config)
 				if err != nil {
-					fmt.Println("coudnot open connection for pod", pod.Name)
 					return "", err
 				}
 				dialer := spdy.NewDialer(upgrader, &http.Client{Transport: transporter}, "POST", req.URL())
@@ -180,7 +181,6 @@ func NewCommand() *cobra.Command {
 					return "", fmt.Errorf("port-forward setup failed: %v", err)
 				}
 				go func() {
-					fmt.Println("FORWARDER WILL RUN FOR ", hostPortStr)
 					if err := forwarder.ForwardPorts(); err != nil {
 						fmt.Println("coud not forward connection for pod", pod.Name)
 					}

pkg/portforward/roundrobin/roundrobin.go

@@ -12,10 +12,11 @@ import (
 type RoundRobin struct {
 	connNumber int
 	mx         sync.Mutex
-	connPool   []string
+	connPool   *[]string
 }
 
-func New(connPool []string) forwarder.Forwarder {
+func New(connPool *[]string) forwarder.Forwarder {
+	fmt.Println("NEW CALLED WITH ", &connPool)
 	return &RoundRobin{
 		connPool: connPool,
 	}
@@ -25,9 +26,16 @@ func (rr *RoundRobin) NextPort() string {
 	defer rr.mx.Unlock()
 
 	initial := rr.connNumber
+	fmt.Println("CONN POOL in next port", &rr.connPool)
+	if rr.connPool == nil {
+		return ""
+	}
+	if len(*rr.connPool) == 0 {
+		return ""
+	}
 	for {
-		rr.connNumber = (rr.connNumber + 1) % len(rr.connPool)
-		portNum := rr.connPool[rr.connNumber]
+		rr.connNumber = (rr.connNumber + 1) % len(*rr.connPool)
+		portNum := (*rr.connPool)[rr.connNumber]
 		if portNum != "" {
 			// Check if port is actually listening
 			conn, err := net.DialTimeout("tcp", ":"+portNum, 50*time.Millisecond)