Add solution for Challenge 18 by clgp-aint-cool#1570
Add solution for Challenge 18 by clgp-aint-cool#1570github-actions[bot] merged 2 commits intoRezaSi:mainfrom
Conversation
WalkthroughA new Go source file for challenge 18 was added implementing temperature conversion functions between Celsius and Fahrenheit with a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b7c2869e-e9c3-469d-a787-babf0aa0ee9b
📒 Files selected for processing (1)
challenge-18/submissions/clgp-aint-cool/solution-template.go
| // TODO: Implement this function | ||
| // Remember to round to 2 decimal places |
There was a problem hiding this comment.
Remove stale TODO comments in implemented logic.
The TODO text says the function is unimplemented, but Line 30 already contains the implementation. Keeping this is misleading during maintenance.
🧹 Suggested cleanup
func FahrenheitToCelsius(fahrenheit float64) float64 {
- // TODO: Implement this function
- // Remember to round to 2 decimal places
return Round((fahrenheit-32)*5/9,2)
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // TODO: Implement this function | |
| // Remember to round to 2 decimal places |
|
🎉 Auto-merged! This PR was automatically merged after 2 days with all checks passing. Thank you for your contribution, @clgp-aint-cool! |
Challenge 18 Solution
Submitted by: @clgp-aint-cool
Challenge: Challenge 18
Description
This PR contains my solution for Challenge 18.
Changes
challenge-18/submissions/clgp-aint-cool/solution-template.goTesting
Thank you for reviewing my submission! 🚀