Fix crash in slider

cmaughan · cmaughan · commit de7b2234b884 · 2026-02-08T16:58:09.000Z
diff --git a/src/widgets/widget_waveslider.cpp b/src/widgets/widget_waveslider.cpp
@@ -178,7 +178,12 @@ void WaveSlider::DrawGeneratedWave(Canvas& canvas, const NRectf& rc)
     rcWorld.Adjust(8, 8, -8, -8);
     for (uint32_t x = 0; x < rcWorld.Width(); x++)
     {
-        auto y = m_wave[size_t(x * m_wave.size() / rc.Width())];
+        auto index = size_t(x * m_wave.size() / rc.Width());
+        if (index >= m_wave.size())
+        {
+            continue;
+        }
+        auto y = m_wave[index];
         if (x == 0)
         {
             canvas.BeginStroke(glm::vec2(rcWorld.Left(), rcWorld.Center().y + y * rcWorld.Height() * 0.5f), 4.0f, waveColor);

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,12 @@ void WaveSlider::DrawGeneratedWave(Canvas& canvas, const NRectf& rc)`
`178`	`178`	`rcWorld.Adjust(8, 8, -8, -8);`
`179`	`179`	`for (uint32_t x = 0; x < rcWorld.Width(); x++)`
`180`	`180`	`{`
`181`		`- auto y = m_wave[size_t(x * m_wave.size() / rc.Width())];`
	`181`	`+ auto index = size_t(x * m_wave.size() / rc.Width());`
	`182`	`+ if (index >= m_wave.size())`
	`183`	`+ {`
	`184`	`+ continue;`
	`185`	`+ }`
	`186`	`+ auto y = m_wave[index];`
`182`	`187`	`if (x == 0)`
`183`	`188`	`{`
`184`	`189`	`canvas.BeginStroke(glm::vec2(rcWorld.Left(), rcWorld.Center().y + y * rcWorld.Height() * 0.5f), 4.0f, waveColor);`