Skip to content

Commit 6dec2e1

Browse files
committed
Refactor HTTP credential UI composition
1 parent ff26f97 commit 6dec2e1

17 files changed

Lines changed: 1256 additions & 1325 deletions

packages/plugins/google-discovery/src/react/AddGoogleDiscoverySource.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import * as Schema from "effect/Schema";
77
import { sourceWriteKeys } from "@executor-js/react/api/reactivity-keys";
88
import { useScope, useUserScope } from "@executor-js/react/api/scope-context";
99
import type { SecretPickerSecret } from "@executor-js/react/plugins/secret-picker";
10-
import { CreatableSecretPicker } from "@executor-js/react/plugins/secret-header-auth";
10+
import { CreatableSecretPicker } from "@executor-js/react/plugins/creatable-secret-picker";
1111
import { useSecretPickerSecrets } from "@executor-js/react/plugins/use-secret-picker-secrets";
1212
import type { ScopeId } from "@executor-js/sdk";
1313
import { Badge } from "@executor-js/react/components/badge";

packages/plugins/graphql/src/react/AddGraphqlSource.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import * as Schema from "effect/Schema";
77
import { useScope } from "@executor-js/react/api/scope-context";
88
import { sourceWriteKeys } from "@executor-js/react/api/reactivity-keys";
99
import {
10-
HttpCredentialsEditor,
10+
HttpCredentials,
1111
httpCredentialsValid,
1212
serializeScopedHttpCredentials,
1313
serializeHttpCredentials,
@@ -177,15 +177,18 @@ export default function AddGraphqlSource(props: {
177177

178178
<GraphqlSourceFields endpoint={endpoint} onEndpointChange={setEndpoint} identity={identity} />
179179

180-
<HttpCredentialsEditor
180+
<HttpCredentials.Root
181181
credentials={credentials}
182182
onChange={setCredentials}
183183
existingSecrets={secretList}
184184
sourceName={identity.name}
185185
targetScope={requestCredentialTargetScope}
186186
credentialScopeOptions={credentialScopeOptions}
187187
bindingScopeOptions={credentialScopeOptions}
188-
/>
188+
>
189+
<HttpCredentials.Headers />
190+
<HttpCredentials.QueryParams />
191+
</HttpCredentials.Root>
189192

190193
{/* Temporarily hidden while we revisit GraphQL OAuth discovery and UX. */}
191194
<section className="hidden space-y-2.5">

packages/plugins/graphql/src/react/EditGraphqlSource.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { useScope, useScopeStack } from "@executor-js/react/api/scope-context";
1212
import { connectionWriteKeys, sourceWriteKeys } from "@executor-js/react/api/reactivity-keys";
1313
import { useSecretPickerSecrets } from "@executor-js/react/plugins/use-secret-picker-secrets";
1414
import {
15-
HttpCredentialsEditor,
15+
HttpCredentials,
1616
serializeHttpCredentials,
1717
serializeScopedHttpCredentials,
1818
type HttpCredentialsState,
@@ -191,15 +191,18 @@ function EditForm(props: {
191191
namespaceReadOnly
192192
/>
193193

194-
<HttpCredentialsEditor
194+
<HttpCredentials.Root
195195
credentials={credentials}
196196
onChange={handleCredentialsChange}
197197
existingSecrets={secretList}
198198
sourceName={identity.name}
199199
targetScope={credentialTargetScope}
200200
credentialScopeOptions={credentialScopeOptions}
201201
bindingScopeOptions={credentialScopeOptions}
202-
/>
202+
>
203+
<HttpCredentials.Headers />
204+
<HttpCredentials.QueryParams />
205+
</HttpCredentials.Root>
203206

204207
{/* Temporarily hidden while we revisit GraphQL OAuth discovery and UX. */}
205208
<section className="hidden space-y-2.5">

0 commit comments

Comments
 (0)