Skip to content

Commit ef35f44

Browse files
committed
lint(desktop): boundary disables in smoke-sidecar harness
1 parent 17cddb5 commit ef35f44

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

apps/desktop/scripts/smoke-sidecar.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,10 @@ const startOpenApiServer = () => {
127127
};
128128

129129
const waitForReadyPort = (proc: Subprocess<"ignore", "pipe", "pipe">): Promise<number> =>
130+
// oxlint-disable-next-line executor/no-promise-reject -- boundary: standalone build-time smoke harness, no Effect runtime
130131
new Promise((resolveReady, rejectReady) => {
131132
const deadline = setTimeout(() => {
133+
// oxlint-disable-next-line executor/no-promise-reject, executor/no-error-constructor -- boundary: standalone smoke harness reporting a build-time timeout
132134
rejectReady(new Error(`sidecar did not announce ready within ${READY_TIMEOUT_MS}ms`));
133135
}, READY_TIMEOUT_MS);
134136

@@ -150,6 +152,7 @@ const waitForReadyPort = (proc: Subprocess<"ignore", "pipe", "pipe">): Promise<n
150152
const { value, done } = await reader.read();
151153
if (done) {
152154
clearTimeout(deadline);
155+
// oxlint-disable-next-line executor/no-promise-reject, executor/no-error-constructor -- boundary: standalone smoke harness, stdout-closed surfaced as rejection
153156
rejectReady(new Error("sidecar stdout closed before ready"));
154157
return;
155158
}
@@ -217,9 +220,11 @@ const main = async () => {
217220
if (exitCode === null) proc.kill("SIGKILL");
218221
}
219222
openapi.server.stop(true);
223+
// oxlint-disable-next-line executor/no-promise-catch -- boundary: best-effort tempdir cleanup in a standalone smoke harness
220224
await rm(scopeDir, { recursive: true, force: true }).catch(() => {});
221225
};
222226

227+
// oxlint-disable-next-line executor/no-try-catch-or-throw -- boundary: standalone smoke harness needs a finally to tear down the spawned binary + http server
223228
try {
224229
const port = await waitForReadyPort(proc);
225230
const mcpUrl = new URL(`http://127.0.0.1:${port}/mcp`);

0 commit comments

Comments
 (0)