Skip to content

Dev: admin seeding requires EXECUTOR_DEV_SEED_ADMIN=1#1269

Merged
RhysSullivan merged 1 commit into
mainfrom
ux/dev-seed-opt-in
Jul 2, 2026
Merged

Dev: admin seeding requires EXECUTOR_DEV_SEED_ADMIN=1#1269
RhysSullivan merged 1 commit into
mainfrom
ux/dev-seed-opt-in

Conversation

@RhysSullivan

Copy link
Copy Markdown
Owner

bun run dev silently seeded admin@example.com into every dev instance, which means developers never see the real first-run setup flow. Several first-run problems survived unnoticed because the team literally could not reach the new-user path by default.

Seeding is now opt-in: set EXECUTOR_DEV_SEED_ADMIN=1 to get the previous behavior (same default credentials). RUNNING.md is updated.

Heads up on the behavior change: every dev server now boots into the real first-run setup unless the variable is exported. If you relied on the implicit admin, add the env var to your shell profile.

Verified by booting dev servers with and without the variable. Typecheck is green.

Stacked on #1268.

@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown

Greptile Summary

This PR makes dev admin seeding opt-in so developers actually exercise the first-run setup flow by default when running bun run dev. Previously, EXECUTOR_BOOTSTRAP_ADMIN_EMAIL and EXECUTOR_BOOTSTRAP_ADMIN_PASSWORD were always injected, silently bypassing new-user onboarding for the whole team.

  • vite.config.ts: The two bootstrap env-var assignments are now wrapped in if (process.env.EXECUTOR_DEV_SEED_ADMIN === "1"), so the seeded admin is only created when explicitly requested.
  • RUNNING.md: A new bullet documents the default first-run-setup behavior and the opt-in variable, including the same credentials the code uses.

Confidence Score: 5/5

Safe to merge — the change is a two-line guard around dev-only env var defaults with no effect on production code paths.

The only files touched are the Vite dev config and a markdown doc. The guard logic is correct and the documented credentials match the code. No production behavior is altered.

No files require special attention.

Important Files Changed

Filename Overview
apps/host-selfhost/vite.config.ts Wraps the two EXECUTOR_BOOTSTRAP_ADMIN_* env-var defaults in an EXECUTOR_DEV_SEED_ADMIN=1 guard, making admin seeding opt-in; logic is correct and the comment block above it remains accurate.
RUNNING.md Adds a bullet documenting the new opt-in env var and the default first-run-setup behavior; credentials match the code defaults.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[bun run dev] --> B{EXECUTOR_DEV_SEED_ADMIN === '1'?}
    B -- Yes --> C[Set EXECUTOR_BOOTSTRAP_ADMIN_EMAIL\nadmin@example.com]
    C --> D[Set EXECUTOR_BOOTSTRAP_ADMIN_PASSWORD\nexecutor-dev-admin]
    D --> E[Dev server boots\nwith seeded admin]
    B -- No --> F[Bootstrap env vars NOT set]
    F --> G[Dev server boots into\nfirst-run setup flow]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[bun run dev] --> B{EXECUTOR_DEV_SEED_ADMIN === '1'?}
    B -- Yes --> C[Set EXECUTOR_BOOTSTRAP_ADMIN_EMAIL\nadmin@example.com]
    C --> D[Set EXECUTOR_BOOTSTRAP_ADMIN_PASSWORD\nexecutor-dev-admin]
    D --> E[Dev server boots\nwith seeded admin]
    B -- No --> F[Bootstrap env vars NOT set]
    F --> G[Dev server boots into\nfirst-run setup flow]
Loading

Reviews (4): Last reviewed commit: "Require opt-in dev admin seeding" | Re-trigger Greptile

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 2, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 5789336 Jul 02 2026, 08:40 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 2, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 5789336 Commit Preview URL

Branch Preview URL
Jul 02 2026, 08:37 PM

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@pkg-pr-new

pkg-pr-new Bot commented Jul 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1269

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1269

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1269

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1269

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1269

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1269

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1269

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1269

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1269

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1269

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1269

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1269

executor

npm i https://pkg.pr.new/executor@1269

commit: d990bce

@RhysSullivan RhysSullivan force-pushed the ux/dev-seed-opt-in branch 2 times, most recently from ffa7ac7 to 5b7c38f Compare July 2, 2026 18:21
@RhysSullivan RhysSullivan force-pushed the ux/command-palette branch 2 times, most recently from a7306f6 to 94c3bd5 Compare July 2, 2026 18:21
@RhysSullivan RhysSullivan force-pushed the ux/dev-seed-opt-in branch 2 times, most recently from 6d86462 to c785006 Compare July 2, 2026 18:21
@RhysSullivan RhysSullivan force-pushed the ux/command-palette branch 2 times, most recently from 334c26e to 35bd531 Compare July 2, 2026 18:22
@RhysSullivan RhysSullivan force-pushed the ux/dev-seed-opt-in branch 2 times, most recently from 1377b4e to 9d2df17 Compare July 2, 2026 18:22
@RhysSullivan RhysSullivan changed the base branch from ux/command-palette to main July 2, 2026 18:22
@RhysSullivan RhysSullivan merged commit 41b75eb into main Jul 2, 2026
19 of 25 checks passed
@RhysSullivan RhysSullivan deleted the ux/dev-seed-opt-in branch July 2, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant