[codex] Cut storage over to FumaDB#817
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | c1e16a7 | Commit Preview URL Branch Preview URL |
May 15 2026, 02:39 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | c1e16a7 | May 15 2026, 02:39 AM |
RhysSullivan
commented
May 14, 2026
RhysSullivan
force-pushed
the
codex/fumadb-cutover
branch
from
20f4ed0 to
f962a13
Compare
RhysSullivan
commented
May 15, 2026
Owner
Author
There was a problem hiding this comment.
why'd we remove embedded migrations
Owner
Author
There was a problem hiding this comment.
This was removed because the local app no longer runs Drizzle migrations from disk. Local now builds the FumaDB SQLite schema from collectTables(...) at startup via FumaDB/Drizzle runtime schema generation, and the legacy SQLite cutover imports rows directly from the old DB into the new Fuma DB. So there is no migration folder for the CLI binary to embed anymore; keeping the old embedded Drizzle migration module would be dead code.
# Conflicts: # bun.lock # packages/core/storage-core/package.json # packages/core/storage-drizzle/package.json # packages/plugins/mcp/src/sdk/probe-shape.test.ts # packages/plugins/mcp/src/sdk/probe-shape.ts
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-google-discovery
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
This is a full storage cutover. The old custom storage model and SDK-owned database helpers are removed rather than kept as compatibility layers. Core stays database-agnostic at runtime, while apps/tests compose the FumaDB database they want.
Coverage Notes
Validation
bun run format:checkbun run lintbun run scripts/check-changelog-stubs.tsbun run --cwd apps/local typecheckbun run --cwd packages/core/sdk typecheckbun run --cwd packages/plugins/mcp typecheckbun run --cwd apps/local test -- src/server/db-upgrade.test.ts src/server/sqlite-import.test.ts src/server/mcp-oauth.test.ts src/server/migrate-openapi-bindings.test.ts src/server/migrate-mcp-bindings.test.ts src/server/migrate-graphql-bindings.test.ts src/server/migrate-google-discovery-bindings.test.ts src/server/migrate-oauth-connections.test.ts src/server/migration-nesting.test.tsbun run --cwd packages/core/sdk test -- src/executor.test.tsbun run --cwd packages/plugins/mcp test -- src/sdk/probe-shape.test.tsnode ../../node_modules/vitest/vitest.mjs run src/mcp-flow.test.tsfromapps/cloud