Add FumaDB table policy interceptors#821
Merged
RhysSullivan merged 4 commits intoMay 14, 2026
Merged
Conversation
RhysSullivan
commented
May 14, 2026
| expect(result.backupPath && existsSync(result.backupPath)).toBe(true); | ||
|
|
||
| const source = (await sqlite.db.findFirst("source", { | ||
| const db = withQueryContext(sqlite.db, { allowedScopeIds: new Set(["scope_a"]) }); |
Owner
Author
There was a problem hiding this comment.
are we giving raw db access that bypasses the filtering we have
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 1f5b254 | May 14 2026, 11:44 PM |
RhysSullivan
commented
May 14, 2026
| sqlite = new Database(options.sqlitePath, { readonly: true }); | ||
| const importedTables: string[] = []; | ||
| let importedRows = 0; | ||
| const dbWithScopeContext = withQueryContext(options.db, { |
Owner
Author
There was a problem hiding this comment.
options.db probs shouldnt exist
RhysSullivan
commented
May 14, 2026
| const rows = toScopeRows( | ||
| yield* Effect.promise(() => | ||
| config.db.findMany("connection", { | ||
| withQueryContext(config.db, { |
Owner
Author
There was a problem hiding this comment.
why isnt .db already scoped
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 1f5b254 | Commit Preview URL Branch Preview URL |
May 14 2026, 11:44 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #817.
Summary
Verification